Skip to content

Commit c88e19b

Browse files
committed
share workerdBuiltinModules
1 parent f524f06 commit c88e19b

File tree

6 files changed

+10
-16
lines changed

6 files changed

+10
-16
lines changed

packages/vitest-pool-workers/src/config/index.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import fs from "node:fs/promises";
44
import { builtinModules } from "node:module";
55
import path from "node:path";
66
import { MessageChannel, receiveMessageOnPort } from "node:worker_threads";
7+
import { workerdBuiltinModules } from "../shared/builtin-modules";
78
import type {
89
WorkersConfigPluginAPI,
910
WorkersPoolOptions,
@@ -111,13 +112,6 @@ function ensureArrayExcludes<T>(array: T[], items: T[]) {
111112
const requiredConditions = ["workerd", "worker", "browser"];
112113
const requiredMainFields = ["browser", "module", "jsnext:main", "jsnext"];
113114

114-
const cloudflareBuiltInModules = [
115-
"cloudflare:email",
116-
"cloudflare:sockets",
117-
"cloudflare:workers",
118-
"cloudflare:workflows",
119-
];
120-
121115
function createConfigPlugin(): Plugin<WorkersConfigPluginAPI> {
122116
// Use a unique ID for each `cloudflare:test` module so updates in one `main`
123117
// don't trigger re-runs in all other projects, just the one that changed.
@@ -162,7 +156,7 @@ function createConfigPlugin(): Plugin<WorkersConfigPluginAPI> {
162156
config.test.deps.optimizer.ssr.enabled ??= true;
163157
config.test.deps.optimizer.ssr.exclude ??= [];
164158
ensureArrayIncludes(config.test.deps.optimizer.ssr.exclude, [
165-
...cloudflareBuiltInModules,
159+
...workerdBuiltinModules,
166160
...builtinModules.concat(builtinModules.map((m) => `node:${m}`)),
167161
]);
168162

packages/vitest-pool-workers/src/pool/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
} from "miniflare";
2424
import semverSatisfies from "semver/functions/satisfies.js";
2525
import { createMethodsRPC } from "vitest/node";
26+
import { workerdBuiltinModules } from "../shared/builtin-modules";
2627
import { createChunkingSocket } from "../shared/chunking-socket";
2728
import { CompatibilityFlagAssertions } from "./compatibility-flag-assertions";
2829
import { OPTIONS_PATH, parseProjectOptions } from "./config";
@@ -41,7 +42,6 @@ import {
4142
import {
4243
ensurePosixLikePath,
4344
handleModuleFallbackRequest,
44-
workerdBuiltinModules,
4545
} from "./module-fallback";
4646
import type {
4747
SourcelessWorkerOptions,

packages/vitest-pool-workers/src/pool/module-fallback.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import util from "node:util";
88
import * as cjsModuleLexer from "cjs-module-lexer";
99
import { buildSync } from "esbuild";
1010
import { ModuleRuleTypeSchema, Response } from "miniflare";
11+
import { workerdBuiltinModules } from "../shared/builtin-modules";
1112
import { isFileNotFoundError } from "./helpers";
1213
import type { ModuleRuleType, Request, Worker_Module } from "miniflare";
1314
import type { ViteDevServer } from "vite";
@@ -67,12 +68,6 @@ const forceModuleTypeRegexp = new RegExp(
6768
`\\?mf_vitest_force=(${ModuleRuleTypeSchema.options.join("|")})$`
6869
);
6970

70-
// Node.js built-in modules provided by `workerd`
71-
export const workerdBuiltinModules = new Set([
72-
...VITEST_POOL_WORKERS_DEFINE_BUILTIN_MODULES,
73-
"__STATIC_CONTENT_MANIFEST",
74-
]);
75-
7671
// `chai` contains circular `require()`s which aren't supported by `workerd`
7772
// TODO(someday): support circular `require()` in `workerd`
7873
const bundleDependencies = ["chai"];
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
// Node.js built-in modules provided by `workerd`
2+
export const workerdBuiltinModules = new Set([
3+
...VITEST_POOL_WORKERS_DEFINE_BUILTIN_MODULES,
4+
"__STATIC_CONTENT_MANIFEST",
5+
]);

packages/vitest-pool-workers/tsconfig.emit.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@
88
"incremental": false
99
},
1010
// Only want to emit `.d.ts` for `/config` sub-export
11-
"include": ["./src/config/**/*.ts"]
11+
"include": ["./src/shared/types-global.d.ts", "./src/config/**/*.ts"]
1212
}

0 commit comments

Comments
 (0)