Skip to content

Commit c8f1e5f

Browse files
authored
Fix Quick Edit and Devtools builds (#3864)
1 parent abfdbb4 commit c8f1e5f

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/quick-edit-extension/scripts/bundle.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ type BuildFlags = {
77

88
async function buildMain(flags: BuildFlags = {}) {
99
const options: esbuild.BuildOptions = {
10-
watch: flags.watch,
1110
entryPoints: ["./src/extension.ts"],
1211
bundle: true,
1312
outfile: "./dist/extension.js",
@@ -40,7 +39,12 @@ async function buildMain(flags: BuildFlags = {}) {
4039
},
4140
],
4241
};
43-
await esbuild.build(options);
42+
if (flags.watch) {
43+
const ctx = await esbuild.context(options);
44+
await ctx.watch();
45+
} else {
46+
await esbuild.build(options);
47+
}
4448
}
4549

4650
async function run() {

packages/wrangler-devtools/Makefile

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ devtools-frontend/out/Default/gen/front_end: devtools-frontend
2020
cd devtools-frontend && PATH=$(PATH_WITH_DEPOT) $(ROOT)/depot/gn gen out/Default
2121
cd devtools-frontend && PATH=$(PATH_WITH_DEPOT) $(ROOT)/depot/autoninja -C out/Default
2222

23-
node_modules:
24-
npm ci
25-
26-
publish: node_modules devtools-frontend/out/Default/gen/front_end
23+
publish: devtools-frontend/out/Default/gen/front_end
2724
npx wrangler pages deploy --project-name cloudflare-devtools devtools-frontend/out/Default/gen/front_end
2825

2926
cleanup:

0 commit comments

Comments
 (0)