Skip to content

Commit ca41ebf

Browse files
CI: compute the name for artifacts correctly (#7963)
In the `run-c3-e2e` GH Action we compute various things from the inputs. In particular using `experimental` and `quarantine`. But it seems that these are converted to strings rather than booleans, so we cannot simple check the truthy state of `inputs.quarantine`, for example since this might have the value `"false"`, which is truthy.
1 parent f57bc4e commit ca41ebf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/actions/run-c3-e2e/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ runs:
3939
git config --global user.email [email protected]
4040
git config --global user.name 'Wrangler automated PR updater'
4141
42-
- name: E2E Tests ${{inputs.experimental && '(experimental)' || ''}}
42+
- name: E2E Tests ${{inputs.experimental == 'true' && '(experimental)' || ''}}
4343
id: run-e2e
4444
shell: bash
4545
run: pnpm run test:e2e --filter create-cloudflare
@@ -57,8 +57,8 @@ runs:
5757
uses: actions/upload-artifact@v4
5858
if: always()
5959
with:
60-
name: e2e-logs${{inputs.quarantine && '-quarantine' || ''}}${{inputs.experimental && '-experimental' || ''}}-${{runner.os}}-${{inputs.packageManager}}
61-
path: packages/create-cloudflare/.e2e-logs${{inputs.experimental && '-experimental' || ''}}
60+
name: e2e-logs${{inputs.quarantine == 'true' && '-quarantine' || ''}}${{inputs.experimental == 'true' && '-experimental' || ''}}-${{runner.os}}-${{inputs.packageManager}}
61+
path: packages/create-cloudflare/.e2e-logs${{inputs.experimental == 'true' && '-experimental' || ''}}
6262
include-hidden-files: true
6363

6464
- name: Fail if errors detected

0 commit comments

Comments
 (0)