update eslint versions and ban direct console usage in Wrangler, Miniflare and C3 (#9861)

* update eslint versions and ban direct console usage in Wrangler, Miniflare and C3

* fixup! update eslint versions and ban direct console usage in Wrangler, Miniflare and C3

* fixup! update eslint versions and ban direct console usage in Wrangler, Miniflare and C3

* fixup! update eslint versions and ban direct console usage in Wrangler, Miniflare and C3

* rebase catchups of new eslint errors

Author: petebacondarwin

packages/cli/package.json

@@ -26,8 +26,8 @@
 		"@clack/prompts": "^0.6.3",
 		"@cloudflare/eslint-config-worker": "workspace:*",
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@typescript-eslint/eslint-plugin": "^6.9.0",
-		"@typescript-eslint/parser": "^6.9.0",
+		"@typescript-eslint/eslint-plugin": "catalog:default",
+		"@typescript-eslint/parser": "catalog:default",
 		"chalk": "^5.2.0",
 		"esbuild": "catalog:default",
 		"log-update": "^5.0.1",

packages/cloudflare-workers-bindings-extension/.eslintrc.json

@@ -14,7 +14,6 @@
 				"format": ["camelCase", "PascalCase"]
 			}
 		],
-		"@typescript-eslint/semi": "warn",
 		"curly": "warn",
 		"eqeqeq": "warn",
 		"no-throw-literal": "warn",

packages/cloudflare-workers-bindings-extension/package.json

@@ -117,8 +117,8 @@
 		"@types/mocha": "^10.0.7",
 		"@types/node": "20.x",
 		"@types/vscode": "^1.92.0",
-		"@typescript-eslint/eslint-plugin": "^7.14.1",
-		"@typescript-eslint/parser": "^7.11.0",
+		"@typescript-eslint/eslint-plugin": "catalog:default",
+		"@typescript-eslint/parser": "catalog:default",
 		"@vscode/test-electron": "^2.4.1",
 		"concurrently": "^8.2.2",
 		"esbuild": "catalog:default",

packages/containers-shared/.eslintrc.json

@@ -14,7 +14,6 @@
 				"format": ["camelCase", "PascalCase"]
 			}
 		],
-		"@typescript-eslint/semi": "warn",
 		"curly": "warn",
 		"eqeqeq": "warn",
 		"no-throw-literal": "warn",

packages/create-cloudflare/.eslintrc.js

@@ -1,6 +1,9 @@
 module.exports = {
 	root: true,
 	extends: ["@cloudflare/eslint-config-worker"],
+	rules: {
+		"no-console": "error",
+	},
 	ignorePatterns: [
 		"dist",
 		"scripts",

packages/create-cloudflare/.prettierrc

@@ -13,6 +13,5 @@
 		"^[.]$",
 		"^[.]/index$",
 		"<TYPES>"
-	],
-	"importOrderTypeScriptVersion": "5.0.4"
+	]
 }

packages/create-cloudflare/e2e/helpers/framework-helpers.ts

@@ -78,6 +78,7 @@ export async function runC3ForFrameworkTest(
 
 	const match = output.replaceAll("\n", "").match(deployedUrlRe);
 	if (!match || !match[1]) {
+		// eslint-disable-next-line no-console
 		console.error(output);
 		expect(false, "Couldn't find deployment url in C3 output").toBe(true);
 		return "";

packages/create-cloudflare/e2e/helpers/index.ts

@@ -90,12 +90,16 @@ export const test = originalTest.extend<{
 		const { logPath, logStream } = createTestLogStream(task);
 
 		onTestFailed(() => {
+			// eslint-disable-next-line no-console
 			console.error("##[group]Logs from failed test:", logPath);
 			try {
+				// eslint-disable-next-line no-console
 				console.error(readFileSync(logPath, "utf8"));
 			} catch {
+				// eslint-disable-next-line no-console
 				console.error("Unable to read log file");
 			}
+			// eslint-disable-next-line no-console
 			console.error("##[endgroup]");
 		});
 

packages/create-cloudflare/e2e/helpers/to-exist.ts

@@ -5,7 +5,9 @@ declare module "vitest" {
 	interface CustomMatchers<R = unknown> {
 		toExist(): R;
 	}
+	// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 	interface Assertion<T> extends CustomMatchers<T> {}
+	// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 	interface AsymmetricMatchersContaining extends CustomMatchers {}
 }
 

packages/create-cloudflare/e2e/tests/frameworks/frameworks.test.ts

@@ -143,6 +143,7 @@ describe
 
 						await verifyTypes(testConfig, frameworkConfig, project.path);
 					} catch (e) {
+						// eslint-disable-next-line no-console
 						console.error("ERROR", e);
 						expect.fail(
 							"Failed due to an exception while running C3. See logs for more details",