fix: minor performance improvement to the url polyfill used by the vitest integration (#6700)

Author: petebacondarwin

.changeset/sixty-bottles-care.md

@@ -0,0 +1,5 @@
+---
+"@cloudflare/vitest-pool-workers": patch
+---
+
+fix: minor performance improvement to the url polyfill used by the vitest integration

packages/vitest-pool-workers/src/worker/lib/node/url.ts

@@ -39,11 +39,12 @@ const backslashRegEx = /\\/g;
 const newlineRegEx = /\n/g;
 const carriageReturnRegEx = /\r/g;
 const tabRegEx = /\t/g;
+const questionRegex = /\?/g;
+const hashRegex = /#/g;
 // https://nodejs.org/api/url.html#urlpathtofileurlpath
 export function pathToFileURL(filepath: string): URL {
 	// https://github.com/denoland/deno_std/blob/01a401c432fd5628efd3a4fafffdc14660efe9e2/node/url.ts#L1391
 	// Thanks 🦖!
-	const outURL = new URL("file://");
 	let resolved = path.resolve(filepath);
 	// path.resolve strips trailing slashes so we must add them back
 	const filePathLast = filepath.charCodeAt(filepath.length - 1);
@@ -53,24 +54,34 @@ export function pathToFileURL(filepath: string): URL {
 	) {
 		resolved += "/";
 	}
-	outURL.pathname = encodePathChars(resolved);
-	return outURL;
+	resolved = encodePathChars(resolved);
+	// Question and hash character should be included in pathname.
+	// Therefore, encoding is required to eliminate parsing them in different states.
+	// This is done as an optimization to not creating a URL instance and
+	// later triggering pathname setter, which impacts performance
+	if (resolved.indexOf("?") !== -1) {
+		resolved = resolved.replace(questionRegex, "%3F");
+	}
+	if (resolved.indexOf("#") !== -1) {
+		resolved = resolved.replace(hashRegex, "%23");
+	}
+	return new URL(`file://${resolved}`);
 }
 function encodePathChars(filepath: string): string {
-	if (filepath.includes("%")) {
+	if (filepath.indexOf("%") !== -1) {
 		filepath = filepath.replace(percentRegEx, "%25");
 	}
 	// In posix, backslash is a valid character in paths:
-	if (filepath.includes("\\")) {
+	if (filepath.indexOf("\\") !== -1) {
 		filepath = filepath.replace(backslashRegEx, "%5C");
 	}
-	if (filepath.includes("\n")) {
+	if (filepath.indexOf("\n") !== -1) {
 		filepath = filepath.replace(newlineRegEx, "%0A");
 	}
-	if (filepath.includes("\r")) {
+	if (filepath.indexOf("\r") !== -1) {
 		filepath = filepath.replace(carriageReturnRegEx, "%0D");
 	}
-	if (filepath.includes("\t")) {
+	if (filepath.indexOf("\t") !== -1) {
 		filepath = filepath.replace(tabRegEx, "%09");
 	}
 	return filepath;