Skip to content

Commit d827d95

Browse files
ci: ensure "Check the changesets" runs before we delete them by running "Bump package versions" (#10222)
This was allowing invalid changesets to be merged to main.
1 parent 48853a6 commit d827d95

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/test-and-check.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ jobs:
4141
turbo-token: ${{ secrets.TURBO_TOKEN }}
4242
turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
4343

44+
- name: Check the changesets
45+
run: node -r esbuild-register tools/deployments/validate-changesets.ts
46+
4447
- name: Bump package versions
4548
run: node .github/changeset-version.js
4649
env:
@@ -52,9 +55,6 @@ jobs:
5255
CI_OS: ${{ runner.os }}
5356
NODE_OPTIONS: "--max_old_space_size=8192"
5457

55-
- name: Check the changesets
56-
run: node -r esbuild-register tools/deployments/validate-changesets.ts
57-
5858
- name: Upload turbo logs
5959
if: always()
6060
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)