Skip to content

Commit db29394

Browse files
committed
fix error
1 parent d9cd1e7 commit db29394

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

packages/miniflare/src/http/fetch.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,8 @@ export class DispatchFetchDispatcher extends undici.Dispatcher {
197197
path: string // Including query parameters
198198
) {
199199
// Reconstruct URL using runtime origin specified with `dispatchFetch()`
200-
// Only set if not already present (e.g., set by #fetcherFetchCall in proxy client)
201-
if (!headers.has(CoreHeaders.ORIGINAL_URL)) {
202-
const originalURL = this.userRuntimeOrigin + path;
203-
headers.set(CoreHeaders.ORIGINAL_URL, originalURL);
204-
}
200+
const originalURL = this.userRuntimeOrigin + path;
201+
headers.set(CoreHeaders.ORIGINAL_URL, originalURL);
205202
headers.set(CoreHeaders.DISABLE_PRETTY_ERROR, "true");
206203
if (this.cfBlobJson !== undefined) {
207204
// Only add this header if a `cf` override was set

packages/miniflare/src/plugins/core/proxy/client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@ class ProxyStubHandler<T extends object>
728728
const request = new Request(this.bridge.url, userRequest);
729729
// If adding new headers here, remember to `delete()` them in `ProxyServer`
730730
// before calling `fetch()`.
731-
request.headers.set(CoreHeaders.ORIGINAL_URL, userRequest.url);
731+
request.headers.set(CoreHeaders.OP_ORIGINAL_URL, userRequest.url);
732732
request.headers.set(CoreHeaders.OP_SECRET, PROXY_SECRET_HEX);
733733
request.headers.set(CoreHeaders.OP, ProxyOps.CALL);
734734
request.headers.set(CoreHeaders.OP_TARGET, this.#stringifiedTarget);

packages/miniflare/src/workers/core/constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export const CoreHeaders = {
4646
OP_SYNC: "MF-Op-Sync",
4747
OP_STRINGIFIED_SIZE: "MF-Op-Stringified-Size",
4848
OP_RESULT_TYPE: "MF-Op-Result-Type",
49+
OP_ORIGINAL_URL: "MF-Op-Original-URL",
4950
} as const;
5051

5152
export const CoreBindings = {

packages/miniflare/src/workers/core/proxy.worker.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,14 +270,17 @@ export class ProxyServer implements DurableObject {
270270

271271
// See `isFetcherFetch()` comment for why this special
272272
if (isFetcherFetch(targetName, keyHeader)) {
273-
const originalUrl = request.headers.get(CoreHeaders.ORIGINAL_URL);
273+
const originalUrl =
274+
request.headers.get(CoreHeaders.OP_ORIGINAL_URL) ??
275+
request.headers.get(CoreHeaders.ORIGINAL_URL);
274276
const url = new URL(originalUrl ?? request.url);
275277
// Create a new request to allow header mutation and use original URL
276278
request = new Request(url, request);
277279
request.headers.delete(CoreHeaders.OP_SECRET);
278280
request.headers.delete(CoreHeaders.OP);
279281
request.headers.delete(CoreHeaders.OP_TARGET);
280282
request.headers.delete(CoreHeaders.OP_KEY);
283+
request.headers.delete(CoreHeaders.OP_ORIGINAL_URL);
281284
request.headers.delete(CoreHeaders.ORIGINAL_URL);
282285
request.headers.delete(CoreHeaders.DISABLE_PRETTY_ERROR);
283286
return func.call(target, request);

0 commit comments

Comments
 (0)