pr feedback

Author: emily-shen

packages/wrangler/src/__tests__/config/configuration.test.ts

@@ -2520,7 +2520,7 @@ describe("normalizeAndValidateConfig()", () => {
 				expect(diagnostics.renderWarnings()).toMatchInlineSnapshot(`
 					"Processing wrangler configuration:
 					  - \\"containers.configuration\\" is deprecated. Use top level \\"containers\\" fields instead. \\"configuration.image\\" should be \\"image\\", \\"configuration.disk\\" should be set via \\"instance_type\\".
-					  - Unexpected fields found in containers.configuration field: \\"invalid_field\\",\\"another_invalid\\""
+					  - Unexpected fields found in containers.configuration field: \\"memory\\",\\"invalid_field\\",\\"another_invalid\\""
 				`);
 			});
 		});

packages/wrangler/src/config/validation.ts

@@ -2504,6 +2504,14 @@ function validateContainerApp(
 				containerAppOptional.max_instances,
 				"number"
 			);
+			if (
+				containerAppOptional.max_instances !== undefined &&
+				containerAppOptional.max_instances < 0
+			) {
+				diagnostics.errors.push(
+					`"containers.max_instances" field should be a positive number, but got ${containerAppOptional.max_instances}`
+				);
+			}
 			validateOptionalProperty(
 				diagnostics,
 				field,
@@ -2565,7 +2573,7 @@ function validateContainerApp(
 					diagnostics,
 					`${field}.configuration`,
 					Object.keys(containerAppOptional.configuration),
-					["image", "secrets", "labels", "disk", "memory", "vcpu", "memory_mib"]
+					["image", "secrets", "labels", "disk", "vcpu", "memory_mib"]
 				);
 			}
 		}