Skip to content

Commit e1713c8

Browse files
bump the VS code JS debug terminal support PR to minor (#9838)
* bump the VS code JS debug terminal support PR to minor * fix c3 e2e when there are only markdown changes
1 parent 8104705 commit e1713c8

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.changeset/perfect-plants-compete.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
"miniflare": patch
3-
"wrangler": patch
2+
"miniflare": minor
3+
"wrangler": minor
44
---
55

66
In 2023 we announced [breakpoint debugging support](https://blog.cloudflare.com/debugging-cloudflare-workers/) for Workers, which meant that you could easily debug your Worker code in Wrangler's built-in devtools (accessible via the `[d]` hotkey) as well as multiple other devtools clients, [including VSCode](https://developers.cloudflare.com/workers/observability/dev-tools/breakpoints/). For most developers, breakpoint debugging via VSCode is the most natural flow, but until now it's required [manually configuring a `launch.json` file](https://developers.cloudflare.com/workers/observability/dev-tools/breakpoints/#setup-vs-code-to-use-breakpoints), running `wrangler dev`, and connecting via VSCode's built-in debugger.

.github/workflows/c3-e2e.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ jobs:
6363
turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
6464

6565
- name: Bump package versions
66+
if: steps.changes.outputs.everything_but_markdown == 'true'
6667
run: node .github/changeset-version.js
6768
env:
6869
GITHUB_TOKEN: ${{ github.token }}
@@ -89,7 +90,7 @@ jobs:
8990

9091
- name: Upload Logs
9192
uses: actions/upload-artifact@v4
92-
if: ${{ !cancelled() }}
93+
if: ${{ !cancelled() || steps.changes.outputs.everything_but_markdown == 'true' }}
9394
with:
9495
name: e2e-logs${{matrix.experimental == 'true' && '-experimental' || ''}}-${{runner.os}}-${{matrix.pm.name}}
9596
path: packages/create-cloudflare/.e2e-logs${{matrix.experimental == 'true' && '-experimental' || ''}}

0 commit comments

Comments
 (0)