fix require("debug") in nodejs_compat mode (#10149)

* fix `require("debug")` in nodejs_compat mode

* fixup! review feedback

---------

Co-authored-by: James Opstad <[email protected]>

Author: vicb

.changeset/nasty-foxes-find.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix `require("debug")` in nodejs_compat mode

packages/wrangler/e2e/unenv-preset/preset.test.ts

@@ -70,8 +70,9 @@ describe.each(testConfigs)(
 					main: join(__dirname, "/worker/index.ts"),
 					compatibility_date: compatibilityDate,
 					compatibility_flags: ["nodejs_compat", ...compatibilityFlags],
+					// Enable `enabled` logs for the `debug` package
 					vars: {
-						DEBUG: "example",
+						DEBUG: "enabled",
 					},
 				}),
 			});

packages/wrangler/e2e/unenv-preset/worker/index.ts

@@ -12,7 +12,8 @@ export const TESTS: Record<string, () => void> = {
 	testTimers,
 	testNet,
 	testTls,
-	testDebug,
+	testImportDebug,
+	testRequireDebug,
 	testHttp,
 	testHttps,
 };
@@ -212,7 +213,7 @@ export async function testTls() {
 	assert.strictEqual(typeof tls.convertALPNProtocols, "function");
 }
 
-export async function testDebug() {
+export async function testImportDebug() {
 	// @ts-expect-error "debug" is an unenv alias, not installed locally
 	const debug = (await import("debug")).default;
 	const logs: string[] = [];
@@ -221,13 +222,35 @@ export async function testDebug() {
 	debug.log = (...args: string[]) =>
 		logs.push(args.map((arg) => arg.toString()).join(" "));
 
-	const exampleLog = debug("example");
-	const testLog = exampleLog.extend("test");
+	// This should log because as `DEBUG` is set to "enabled".
+	const enabledLog = debug("enabled");
+	enabledLog("This should be logged");
 
-	exampleLog("This is an example log");
-	testLog("This is a test log");
+	// This should not log as `DEBUG` does not contain "enabled:disabled"
+	const disabledLog = enabledLog.extend("disabled");
+	disabledLog("This should not be logged");
 
-	assert.deepEqual(logs, ["example This is an example log +0ms"]);
+	assert.deepEqual(logs, ["enabled This should be logged +0ms"]);
+}
+
+export async function testRequireDebug() {
+	// eslint-disable-next-line @typescript-eslint/no-require-imports
+	const debug = require("debug");
+	const logs: string[] = [];
+
+	// Append all logs to the array instead of logging to console
+	debug.log = (...args: string[]) =>
+		logs.push(args.map((arg) => arg.toString()).join(" "));
+
+	// This should log because as `DEBUG` is set to "enabled".
+	const enabledLog = debug("enabled");
+	enabledLog("This should be logged");
+
+	// This should not log as `DEBUG` does not contain "enabled:disabled"
+	const disabledLog = enabledLog.extend("disabled");
+	disabledLog("This should not be logged");
+
+	assert.deepEqual(logs, ["enabled This should be logged +0ms"]);
 }
 
 export async function testHttp() {

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts

@@ -143,6 +143,7 @@ function handleUnenvAliasedPackages(
 		if (
 			args.kind === "require-call" &&
 			(unresolvedAlias.startsWith("unenv/npm/") ||
+				unresolvedAlias.startsWith("@cloudflare/unenv-preset/npm/") ||
 				unresolvedAlias.startsWith("unenv/mock/"))
 		) {
 			return {