Skip to content

Commit eb0912d

Browse files
fix(create-cloudflare): make DNS poling copy more user friendly (#8215)
* fix(create-cloudflare): make DNS poling copy more user friendly * Update packages/create-cloudflare/src/helpers/poll.ts * Update packages/create-cloudflare/src/helpers/poll.ts
1 parent 47f56a2 commit eb0912d

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

.changeset/large-hotels-create.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"create-cloudflare": patch
3+
---
4+
5+
This change makes the user facing message C3 displays while waiting for DNS propagation, more friendly/informative. The idea is to inform users that DNS propagation might sometimes take even up to 2 minutes. This will hopefully prevent confusion around whether how long the process will take, or whether the process is stuck, etc.

packages/create-cloudflare/src/helpers/poll.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const poll = async (url: string): Promise<boolean> => {
2222
const domain = new URL(url).host;
2323
const s = spinner();
2424

25-
s.start("Waiting for DNS to propagate");
25+
s.start("Waiting for DNS to propagate. This might take a few minutes.");
2626

2727
// Start out by sleeping for 10 seconds since it's unlikely DNS changes will
2828
// have propogated before then
@@ -47,7 +47,9 @@ const pollDns = async (
4747
s: ReturnType<typeof spinner>,
4848
) => {
4949
while (Date.now() - start < TIMEOUT) {
50-
s.update(`Waiting for DNS to propagate (${secondsSince(start)}s)`);
50+
s.update(
51+
`Waiting for DNS to propagate. This might take a few minutes. (${secondsSince(start)}s)`,
52+
);
5153
if (await isDomainResolvable(domain)) {
5254
s.stop(`${brandColor("DNS propagation")} ${dim("complete")}.`);
5355
return;

0 commit comments

Comments
 (0)