WC-3584 Refactor routing to asset or user worker

Centralizing some of these pieces will make it easier to add free tier
limiting

Author: matthewdavidrodgers

packages/workers-shared/router-worker/src/worker.ts

@@ -77,6 +77,39 @@ export default {
 
 			const maybeSecondRequest = request.clone();
 
+			let asset: "static_routing" | "ignored" | true | false = false;
+
+			const routeToUserWorker = async () => {
+				if (!config.has_user_worker) {
+					throw new Error(
+						"Fetch for user worker without having a user worker binding"
+					);
+				}
+				analytics.setData({ dispatchtype: DISPATCH_TYPE.WORKER });
+				userWorkerInvocation = true;
+				return env.JAEGER.enterSpan("dispatch_worker", async (span) => {
+					span.setTags({
+						hasUserWorker: true,
+						asset: asset,
+						dispatchType: DISPATCH_TYPE.WORKER,
+					});
+					return env.USER_WORKER.fetch(maybeSecondRequest);
+				});
+			};
+
+			const routeToAssets = async () => {
+				analytics.setData({ dispatchtype: DISPATCH_TYPE.ASSETS });
+				return await env.JAEGER.enterSpan("dispatch_assets", async (span) => {
+					span.setTags({
+						hasUserWorker: config.has_user_worker,
+						asset: asset,
+						dispatchType: DISPATCH_TYPE.ASSETS,
+					});
+
+					return env.ASSET_WORKER.fetch(maybeSecondRequest);
+				});
+			};
+
 			if (config.static_routing) {
 				// evaluate "exclude" rules
 				const excludeRulesMatcher = generateStaticRoutingRuleMatcher(
@@ -89,18 +122,10 @@ export default {
 				) {
 					// direct to asset worker
 					analytics.setData({
-						dispatchtype: DISPATCH_TYPE.ASSETS,
 						staticRoutingDecision: STATIC_ROUTING_DECISION.ROUTED,
 					});
-					return await env.JAEGER.enterSpan("dispatch_assets", async (span) => {
-						span.setTags({
-							hasUserWorker: config.has_user_worker,
-							asset: "static_routing",
-							dispatchType: DISPATCH_TYPE.ASSETS,
-						});
-
-						return env.ASSET_WORKER.fetch(maybeSecondRequest);
-					});
+					asset = "static_routing";
+					return await routeToAssets();
 				}
 				// evaluate "include" rules
 				const includeRulesMatcher = generateStaticRoutingRuleMatcher(
@@ -118,19 +143,10 @@ export default {
 					}
 					// direct to user worker
 					analytics.setData({
-						dispatchtype: DISPATCH_TYPE.WORKER,
 						staticRoutingDecision: STATIC_ROUTING_DECISION.ROUTED,
 					});
-					return await env.JAEGER.enterSpan("dispatch_worker", async (span) => {
-						span.setTags({
-							hasUserWorker: true,
-							asset: "static_routing",
-							dispatchType: DISPATCH_TYPE.WORKER,
-						});
-
-						userWorkerInvocation = true;
-						return env.USER_WORKER.fetch(maybeSecondRequest);
-					});
+					asset = "static_routing";
+					return await routeToUserWorker();
 				}
 
 				analytics.setData({
@@ -143,53 +159,19 @@ export default {
 			// User's configuration indicates they want user-Worker to run ahead of any
 			// assets. Do not provide any fallback logic.
 			if (config.invoke_user_worker_ahead_of_assets) {
-				if (!config.has_user_worker) {
-					throw new Error(
-						"Fetch for user worker without having a user worker binding"
-					);
-				}
-
-				analytics.setData({ dispatchtype: DISPATCH_TYPE.WORKER });
-				return await env.JAEGER.enterSpan("dispatch_worker", async (span) => {
-					span.setTags({
-						hasUserWorker: true,
-						asset: "ignored",
-						dispatchType: DISPATCH_TYPE.WORKER,
-					});
-
-					userWorkerInvocation = true;
-					return env.USER_WORKER.fetch(maybeSecondRequest);
-				});
+				asset = "ignored";
+				return await routeToUserWorker();
 			}
 
 			// If we have a user-Worker, but no assets, dispatch to Worker script
 			const assetsExist = await env.ASSET_WORKER.unstable_canFetch(request);
+			asset = assetsExist;
 			if (config.has_user_worker && !assetsExist) {
-				analytics.setData({ dispatchtype: DISPATCH_TYPE.WORKER });
-
-				return await env.JAEGER.enterSpan("dispatch_worker", async (span) => {
-					span.setTags({
-						hasUserWorker: config.has_user_worker,
-						asset: assetsExist,
-						dispatchType: DISPATCH_TYPE.WORKER,
-					});
-
-					userWorkerInvocation = true;
-					return env.USER_WORKER.fetch(maybeSecondRequest);
-				});
+				return await routeToUserWorker();
 			}
 
 			// Otherwise, we either don't have a user worker, OR we have matching assets and should fetch from the assets binding
-			analytics.setData({ dispatchtype: DISPATCH_TYPE.ASSETS });
-			return await env.JAEGER.enterSpan("dispatch_assets", async (span) => {
-				span.setTags({
-					hasUserWorker: config.has_user_worker,
-					asset: assetsExist,
-					dispatchType: DISPATCH_TYPE.ASSETS,
-				});
-
-				return env.ASSET_WORKER.fetch(maybeSecondRequest);
-			});
+			return await routeToAssets();
 		} catch (err) {
 			if (userWorkerInvocation) {
 				// Don't send user Worker errors to sentry; we have no way to distinguish between