Skip to content

Commit ee76d26

Browse files
committed
fix logging issues
1 parent 256374e commit ee76d26

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

packages/wrangler/src/dev.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ import type {
5454
} from "./deployment-bundle/worker";
5555
import type { WorkerRegistry } from "./dev-registry";
5656
import type { CfAccount } from "./dev/create-worker-preview";
57-
import type { LoggerLevel } from "./logger";
5857
import type { EnablePagesAssetsServiceBindingOptions } from "./miniflare-cli/types";
5958
import type { watch } from "chokidar";
6059
import type { Json } from "miniflare";
@@ -310,8 +309,6 @@ export const dev = createCommand({
310309
"log-level": {
311310
choices: ["debug", "info", "log", "warn", "error", "none"] as const,
312311
describe: "Specify logging level",
313-
// Yargs requires this to type log-level properly
314-
default: "log" as LoggerLevel,
315312
},
316313
"show-interactive-dev-session": {
317314
describe:
@@ -666,10 +663,6 @@ export async function startDev(args: StartDevOptions) {
666663

667664
let unregisterHotKeys: (() => void) | undefined;
668665
try {
669-
if (args.logLevel) {
670-
logger.loggerLevel = args.logLevel;
671-
}
672-
673666
if (args.experimentalLocal) {
674667
logger.warn(
675668
"--experimental-local is no longer required and will be removed in a future version.\n`wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉"

packages/wrangler/src/index.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -329,11 +329,6 @@ export function createCLIParser(argv: string[]) {
329329
alias: ["x-versions", "experimental-gradual-rollouts"],
330330
})
331331
.check((args) => {
332-
// Update logger level, before we do any logging
333-
if (Object.keys(LOGGER_LEVELS).includes(args.logLevel as string)) {
334-
logger.loggerLevel = args.logLevel as LoggerLevel;
335-
}
336-
337332
// Grab locally specified env params from `.env` file
338333
const loaded = loadDotEnv(".env", args.env);
339334
for (const [key, value] of Object.entries(loaded?.parsed ?? {})) {
@@ -1056,6 +1051,10 @@ export async function main(argv: string[]): Promise<void> {
10561051
// Register Yargs middleware to record command as Sentry breadcrumb
10571052
let recordedCommand = false;
10581053
const wranglerWithMiddleware = wrangler.middleware((args) => {
1054+
// Update logger level, before we do any logging
1055+
if (Object.keys(LOGGER_LEVELS).includes(args.logLevel as string)) {
1056+
logger.loggerLevel = args.logLevel as LoggerLevel;
1057+
}
10591058
// Middleware called for each sub-command, but only want to record once
10601059
if (recordedCommand) {
10611060
return;

packages/wrangler/src/metrics/helpers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import os from "node:os";
22
import { version as wranglerVersion } from "../../package.json";
3-
import { configFormat } from "../config";
43

54
export function getWranglerVersion() {
65
return wranglerVersion;

0 commit comments

Comments
 (0)