[wrangler] improve formatting of cache options in hyperdrive list command (#8703)

Co-authored-by: knickish <[email protected]>

Author: CarmenPopoviciu

.changeset/good-taxis-repeat.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Improve formatting of cache options for hyperdrive list command

packages/wrangler/src/__tests__/hyperdrive.test.ts

@@ -545,13 +545,13 @@ describe("hyperdrive commands", () => {
 		await runWrangler("hyperdrive list");
 		expect(std.out).toMatchInlineSnapshot(`
 			"📋 Listing Hyperdrive configs
-			┌──────────────────────────────────────┬─────────┬────────┬────────────────┬──────┬──────────┬───────────────────┐
-			│ id                                   │ name    │ user   │ host           │ port │ database │ caching           │
-			├──────────────────────────────────────┼─────────┼────────┼────────────────┼──────┼──────────┼───────────────────┤
-			│ xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx │ test123 │ test   │ example.com    │ 5432 │ neondb   │                   │
-			├──────────────────────────────────────┼─────────┼────────┼────────────────┼──────┼──────────┼───────────────────┤
-			│ yyyyyyyy-yyyy-yyyy-yyyy-yyyyyyyyyyyy │ new-db  │ dbuser │ www.google.com │ 3211 │ mydb     │ {\\"disabled\\":true} │
-			└──────────────────────────────────────┴─────────┴────────┴────────────────┴──────┴──────────┴───────────────────┘"
+			┌──────────────────────────────────────┬─────────┬────────┬────────────────┬──────┬──────────┬──────────┐
+			│ id                                   │ name    │ user   │ host           │ port │ database │ caching  │
+			├──────────────────────────────────────┼─────────┼────────┼────────────────┼──────┼──────────┼──────────┤
+			│ xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx │ test123 │ test   │ example.com    │ 5432 │ neondb   │ enabled  │
+			├──────────────────────────────────────┼─────────┼────────┼────────────────┼──────┼──────────┼──────────┤
+			│ yyyyyyyy-yyyy-yyyy-yyyy-yyyyyyyyyyyy │ new-db  │ dbuser │ www.google.com │ 3211 │ mydb     │ disabled │
+			└──────────────────────────────────────┴─────────┴────────┴────────────────┴──────┴──────────┴──────────┘"
 		`);
 	});
 

packages/wrangler/src/hyperdrive/list.ts

@@ -1,6 +1,7 @@
 import { readConfig } from "../config";
 import { logger } from "../logger";
 import { listConfigs } from "./client";
+import { formatCachingOptions } from "./shared";
 import type {
 	CommonYargsArgv,
 	StrictYargsOptionsToInterface,
@@ -25,7 +26,7 @@ export async function handler(
 			host: database.origin.host ?? "",
 			port: database.origin.port?.toString() ?? "",
 			database: database.origin.database ?? "",
-			caching: JSON.stringify(database.caching),
+			caching: formatCachingOptions(database.caching),
 		}))
 	);
 }

packages/wrangler/src/hyperdrive/shared.ts

@@ -0,0 +1,23 @@
+import type { CachingOptions } from "./client";
+
+export function formatCachingOptions(
+	cachingOptions: CachingOptions | undefined
+): string {
+	switch (cachingOptions?.disabled) {
+		case false: {
+			if (cachingOptions.stale_while_revalidate === 0) {
+				return `max_age: ${cachingOptions.max_age}, stale_while_revalidate: disabled`;
+			} else {
+				return `max_age: ${cachingOptions.max_age}, stale_while_revalidate: ${cachingOptions.stale_while_revalidate}`;
+			}
+		}
+		case undefined: {
+			return "enabled";
+		}
+		case true: {
+			return "disabled";
+		}
+		default:
+			return JSON.stringify(cachingOptions);
+	}
+}