Skip to content

Commit f2b0b40

Browse files
committed
normalise all args
1 parent 6df3c69 commit f2b0b40

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

packages/wrangler/src/__tests__/metrics.test.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -207,15 +207,10 @@ describe("metrics", () => {
207207
argsCombination: "j, search, xGradualRollouts, xJsonConfig, xVersions",
208208
command: "wrangler docs",
209209
args: {
210-
"experimental-json-config": true,
210+
xJsonConfig: true,
211211
j: true,
212-
experimentalJsonConfig: true,
213-
"experimental-versions": true,
214-
"x-versions": true,
215-
"experimental-gradual-rollouts": true,
216212
xVersions: true,
217-
experimentalGradualRollouts: true,
218-
experimentalVersions: true,
213+
xGradualRollouts: true,
219214
search: ["<REDACTED>"],
220215
},
221216
};
@@ -448,13 +443,15 @@ describe("metrics", () => {
448443
default: false,
449444
array: ["beep", "boop"],
450445
secretArray: ["beep", "boop"],
446+
// Note how
447+
"secret-array": ["beep", "boop"],
451448
number: 42,
452449
string: "secret",
453450
secretString: "secret",
454451
};
455452

456453
const redacted = redactArgValues(args, ["string", "array"]);
457-
expect(redacted).toMatchObject({
454+
expect(redacted).toEqual({
458455
default: false,
459456
array: ["beep", "boop"],
460457
secretArray: ["<REDACTED>", "<REDACTED>"],

packages/wrangler/src/metrics/metrics-dispatcher.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,8 @@ export const redactArgValues = (
248248
) => {
249249
const result: Record<string, unknown> = {};
250250

251-
for (const [key, value] of Object.entries(args)) {
251+
for (const [k, value] of Object.entries(args)) {
252+
const key = normalise(k);
252253
if (exclude.has(key)) {
253254
continue;
254255
}

0 commit comments

Comments
 (0)