WC-3776 Require confirm for delete when Pages project binds to worker (#10187)

EWC changes add the new "pages_function" boolean field to the service
reference API when a pages function has a service binding to this
worker, and requires "force=true" when deleting

Co-authored-by: Matthew Rodgers <[email protected]>

Author: workers-devprod

.changeset/hip-sites-camp.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Deleting when Pages project binds to worker requires confirmation

packages/wrangler/src/__tests__/delete.test.ts

@@ -384,6 +384,99 @@ Are you sure you want to continue?`,
 			}
 		`);
 		});
+
+		it("should prompt for extra confirmation when worker is used by a Pages function", async () => {
+			mockConfirm({
+				text: `Are you sure you want to delete test-name? This action cannot be undone.`,
+				result: true,
+			});
+			mockConfirm({
+				text: `test-name is currently in use by other Workers:
+
+- A Pages project has a Service Binding to this Worker
+
+You can still delete this Worker, but doing so WILL BREAK the Workers that depend on it. This will cause unexpected failures, and cannot be undone.
+Are you sure you want to continue?`,
+				result: true,
+			});
+			writeWranglerConfig();
+			mockListKVNamespacesRequest();
+			mockListReferencesRequest("test-name", {
+				services: {
+					incoming: [],
+					outgoing: [],
+					pages_function: true,
+				},
+			});
+			mockListTailsByConsumerRequest("test-name");
+			mockDeleteWorkerRequest({ force: true });
+			await runWrangler("delete");
+
+			expect(std).toMatchInlineSnapshot(`
+			Object {
+			  "debug": "",
+			  "err": "",
+			  "info": "",
+			  "out": "Successfully deleted test-name",
+			  "warn": "",
+			}
+		`);
+		});
+
+		it("should include Pages function in confirmation when combined with other dependencies", async () => {
+			mockConfirm({
+				text: `Are you sure you want to delete test-name? This action cannot be undone.`,
+				result: true,
+			});
+			mockConfirm({
+				text: `test-name is currently in use by other Workers:
+
+- Worker existing-worker (production) uses this Worker as a Service Binding
+- A Pages project has a Service Binding to this Worker
+- Worker do-binder (production) has a binding to the Durable Object Namespace "actor_ns" implemented by this Worker
+
+You can still delete this Worker, but doing so WILL BREAK the Workers that depend on it. This will cause unexpected failures, and cannot be undone.
+Are you sure you want to continue?`,
+				result: true,
+			});
+			writeWranglerConfig();
+			mockListKVNamespacesRequest();
+			mockListReferencesRequest("test-name", {
+				services: {
+					incoming: [
+						{
+							service: "existing-worker",
+							environment: "production",
+							name: "BINDING",
+						},
+					],
+					outgoing: [],
+					pages_function: true,
+				},
+				durable_objects: [
+					{
+						service: "do-binder",
+						environment: "production",
+						name: "ACTOR",
+						durable_object_namespace_id: "123",
+						durable_object_namespace_name: "actor_ns",
+					},
+				],
+			});
+			mockListTailsByConsumerRequest("test-name");
+			mockDeleteWorkerRequest({ force: true });
+			await runWrangler("delete");
+
+			expect(std).toMatchInlineSnapshot(`
+			Object {
+			  "debug": "",
+			  "err": "",
+			  "info": "",
+			  "out": "Successfully deleted test-name",
+			  "warn": "",
+			}
+		`);
+		});
 	});
 });
 

packages/wrangler/src/delete.ts

@@ -35,6 +35,7 @@ export type ServiceReferenceResponse = {
 	services?: {
 		incoming: ServiceReference[];
 		outgoing: ServiceReference[];
+		pages_function?: boolean;
 	};
 	durable_objects?: DurableObjectServiceReference[];
 	dispatch_outbounds?: DispatchOutboundsServiceReference[];
@@ -196,6 +197,10 @@ function isUsedAsServiceBinding(references: ServiceReferenceResponse) {
 	return (references.services?.incoming.length || 0) > 0;
 }
 
+function isUsedByPagesFunction(references: ServiceReferenceResponse) {
+	return references.services?.pages_function === true;
+}
+
 function isUsedAsDurableObjectNamespace(
 	references: ServiceReferenceResponse,
 	scriptName: string
@@ -226,6 +231,7 @@ async function checkAndConfirmForceDeleteIfNecessary(
 	);
 	const isDependentService =
 		isUsedAsServiceBinding(references) ||
+		isUsedByPagesFunction(references) ||
 		isUsedAsDurableObjectNamespace(references, scriptName) ||
 		isUsedAsDispatchOutbound(references) ||
 		isUsedAsTailConsumer(tailProducers);
@@ -240,6 +246,11 @@ async function checkAndConfirmForceDeleteIfNecessary(
 			`- Worker ${dependentScript} uses this Worker as a Service Binding`
 		);
 	}
+	if (isUsedByPagesFunction(references)) {
+		dependentMessages.push(
+			`- A Pages project has a Service Binding to this Worker`
+		);
+	}
 	for (const implementedDOBindingReference of references.durable_objects ||
 		[]) {
 		if (implementedDOBindingReference.service === scriptName) {