.gitignore stuff (#8440)

* vite-plugin: add .gitignore update to README

* c3: tighten up .gitignore processing

Author: petebacondarwin

.changeset/deep-owls-travel.md

@@ -0,0 +1,5 @@
+---
+"create-cloudflare": patch
+---
+
+tighten up .gitignore processing

packages/create-cloudflare/src/__tests__/templates.test.ts

@@ -87,7 +87,7 @@ describe("addWranglerToGitIgnore", () => {
 
 			# wrangler files
 			.wrangler
-			.dev.vars
+			.dev.vars*
 			"
 		`);
 	});
@@ -202,7 +202,7 @@ describe("addWranglerToGitIgnore", () => {
 
 			# wrangler files
 			.wrangler
-			.dev.vars
+			.dev.vars*
 			"
 		`);
 	});
@@ -239,7 +239,7 @@ describe("addWranglerToGitIgnore", () => {
 		);
 		expect(appendFileResults.content).toMatchInlineSnapshot(`
 			"
-			.dev.vars
+			.dev.vars*
 			"
 		`);
 	});

packages/create-cloudflare/src/helpers/__tests__/args.test.ts

@@ -112,17 +112,18 @@ describe("Cli", () => {
 			]);
 		});
 
-		const stringArgs = [
-			"--framework",
-			"--template",
-			"--type",
-			"--existing-script",
-		];
+		const stringArgs = ["framework", "template", "type", "existing-script"];
 		test.each(stringArgs)("%s requires an argument", async (arg) => {
-			await expect(parseArgs(["my-react-project", arg])).resolves.toEqual({
+			const logSpy = vi.spyOn(console, "error").mockImplementation(() => {});
+			await expect(
+				parseArgs(["my-react-project", `--${arg}`]),
+			).resolves.toEqual({
 				type: "unknown",
 				args: null,
 			});
+			expect(logSpy).toHaveBeenCalledWith(
+				expect.stringContaining(`Not enough arguments following: ${arg}`),
+			);
 		});
 	});
 });

packages/create-cloudflare/src/templates.ts

@@ -836,14 +836,21 @@ export const addWranglerToGitIgnore = (ctx: C3Context) => {
 	}
 
 	const existingGitIgnoreContent = readFile(gitIgnorePath);
+	const wranglerGitIgnoreFilesToAdd: string[] = [];
 
-	const wranglerGitIgnoreFiles = [".wrangler", ".dev.vars"] as const;
-	const wranglerGitIgnoreFilesToAdd = wranglerGitIgnoreFiles.filter(
-		(file) =>
-			!existingGitIgnoreContent.match(
-				new RegExp(`\n${file}${file === ".wrangler" ? "/?" : ""}\\s+(#'*)?`),
-			),
+	const hasDotWrangler = existingGitIgnoreContent.match(
+		/^\/?\.wrangler(\/|\s|$)/m,
 	);
+	if (!hasDotWrangler) {
+		wranglerGitIgnoreFilesToAdd.push(".wrangler");
+	}
+
+	const hasDotDevDotVars = existingGitIgnoreContent.match(
+		/^\/?\.dev\.vars(\.?\*)?(\s|$)/m,
+	);
+	if (!hasDotDevDotVars) {
+		wranglerGitIgnoreFilesToAdd.push(".dev.vars*");
+	}
 
 	if (wranglerGitIgnoreFilesToAdd.length === 0) {
 		return;
@@ -857,7 +864,7 @@ export const addWranglerToGitIgnore = (ctx: C3Context) => {
 		...(!existingGitIgnoreContent.match(/\n\s*$/) ? [""] : []),
 	];
 
-	if (wranglerGitIgnoreFilesToAdd.length === wranglerGitIgnoreFiles.length) {
+	if (wranglerGitIgnoreFilesToAdd.length > 1) {
 		linesToAppend.push("# wrangler files");
 	}
 

packages/vite-plugin-cloudflare/README.md

@@ -140,6 +140,15 @@ The `directory` in the output configuration will automatically point to the clie
 > This output file is a snapshot of your configuration at the time of the build and is modified to reference your build artifacts.
 > It is the configuration that is used for preview and deployment.
 
+#### Update the .gitignore file
+
+Wrangler will use and/or generate temporary files that should not be stored in git. Add the following lines to the `.gitignore` file:
+
+```gitignore
+.wrangler
+.dev.vars
+```
+
 #### Run the development server
 
 Run `npm run dev` to verify that your application is working as expected.