fix(miniflare): service binding fetch over dev registry should work without host header (#10058)

Author: edmundhung

.changeset/clever-wasps-call.md

@@ -0,0 +1,5 @@
+---
+"miniflare": patch
+---
+
+fix: service binding fetch over dev registry should work without host header

fixtures/dev-registry/workers/module-worker.ts

@@ -39,7 +39,7 @@ export default {
 			}
 
 			if (service && testMethod === "fetch") {
-				return await service.fetch(url, request);
+				return await service.fetch(url);
 			}
 
 			if (testMethod === "tail") {

packages/miniflare/src/index.ts

@@ -1534,7 +1534,14 @@ export class Miniflare {
 
 		return new Promise((resolve) => {
 			const server = stoppable(
-				http.createServer(this.#handleLoopback),
+				http.createServer(
+					{
+						// There might be no HOST header when proxying a fetch request made over service binding
+						//  e.g. env.MY_WORKER.fetch("https://example.com")
+						requireHostHeader: false,
+					},
+					this.#handleLoopback
+				),
 				/* grace */ 0
 			);
 			server.on("connect", this.#handleLoopbackConnect);

packages/miniflare/src/plugins/core/errors/callsite.ts

@@ -130,8 +130,8 @@ export class CallSite implements NodeJS.CallSite {
 	getMethodName(): string | null {
 		return this.opts.methodName;
 	}
-	getFileName(): string | undefined {
-		return this.opts.fileName ?? undefined;
+	getFileName(): string | null {
+		return this.opts.fileName ?? null;
 	}
 	getScriptNameOrSourceURL(): string {
 		return this.opts.fileName;

packages/miniflare/test/dev-registry.spec.ts

@@ -74,7 +74,7 @@ test("DevRegistry: fetch to module worker", async (t) => {
 		script: `
 			export default {
 				async fetch(request, env, ctx) {
-					const response = await env.SERVICE.fetch(request);
+					const response = await env.SERVICE.fetch(request.url);
 					const text = await response.text();
 
 					return new Response("Response from remote worker: " + text, {
@@ -101,7 +101,7 @@ test("DevRegistry: fetch to module worker", async (t) => {
 		script: `
 			export default {
 				async fetch(request, env, ctx) {
-                    const url = new URL(request.url, 'http://placeholder');
+                    const url = new URL(request.url);
                     const name = url.searchParams.get("name") ?? 'anonymous';
 
 					return new Response("Hello " + name);

packages/vitest-pool-workers/src/worker/index.ts

@@ -43,11 +43,11 @@ Object.setPrototypeOf(process, events.EventEmitter.prototype); // Required by `v
 globalThis.__console = console;
 
 // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-function getCallerFileName(of: Function) {
+function getCallerFileName(of: Function): string | null {
 	const originalStackTraceLimit = Error.stackTraceLimit;
 	const originalPrepareStackTrace = Error.prepareStackTrace;
 	try {
-		let fileName: string | undefined = undefined;
+		let fileName: string | null = null;
 		Error.stackTraceLimit = 1;
 		Error.prepareStackTrace = (_error, callSites) => {
 			fileName = callSites[0]?.getFileName();

packages/wrangler/src/sourcemap.ts

@@ -281,8 +281,8 @@ class CallSite implements NodeJS.CallSite {
 	getMethodName(): string | null {
 		return this.opts.methodName;
 	}
-	getFileName(): string | undefined {
-		return this.opts.fileName ?? undefined;
+	getFileName(): string | null {
+		return this.opts.fileName ?? null;
 	}
 	getScriptNameOrSourceURL(): string {
 		return this.opts.fileName;

pnpm-lock.yaml

@@ -16,7 +16,7 @@ packages:
 # Quick Editor update | Every quarter | Update VSCode dependency and patches
 
 catalog:
-  "@types/node": "^20.17.32"
+  "@types/node": "^20.19.9"
   "@typescript-eslint/eslint-plugin": "^8.35.1"
   "@typescript-eslint/parser": "^8.35.1"
   "@vitest/runner": ~3.2.0