Update error message for KV to be shorter (#7996)

Author: WillTaylorDev

.changeset/thin-countries-clean.md

@@ -0,0 +1,5 @@
+---
+"@cloudflare/workers-shared": patch
+---
+
+Provide shorter message for KV GET errors.

packages/workers-shared/asset-worker/src/utils/kv.ts

@@ -43,9 +43,9 @@ export async function getAssetWithMetadataFromKV(
 			return asset;
 		} catch (err) {
 			if (attempts >= retries) {
-				let message = `Requested asset ${assetKey} could not be fetched from KV namespace.`;
+				let message = `KV GET ${assetKey} failed.`;
 				if (err instanceof Error) {
-					message = `Requested asset ${assetKey} could not be fetched from KV namespace: ${err.message}`;
+					message = `KV GET ${assetKey} failed: ${err.message}`;
 				}
 				throw new Error(message);
 			}

packages/workers-shared/asset-worker/tests/kv.test.ts

@@ -45,19 +45,15 @@ describe("[Asset Worker] Fetching assets from KV", () => {
 
 			await expect(() =>
 				getAssetWithMetadataFromKV(mockKVNamespace, "abcd")
-			).rejects.toThrowError(
-				"Requested asset abcd could not be fetched from KV namespace."
-			);
+			).rejects.toThrowError("KV GET abcd failed.");
 		});
 
 		it("should retry once by default if something went wrong while fetching the asset", async () => {
 			spy.mockReturnValue(Promise.reject("Oeps! Something went wrong"));
 
 			await expect(() =>
 				getAssetWithMetadataFromKV(mockKVNamespace, "abcd")
-			).rejects.toThrowError(
-				"Requested asset abcd could not be fetched from KV namespace."
-			);
+			).rejects.toThrowError("KV GET abcd failed.");
 			expect(spy).toHaveBeenCalledTimes(2);
 		});
 
@@ -66,12 +62,21 @@ describe("[Asset Worker] Fetching assets from KV", () => {
 
 			await expect(() =>
 				getAssetWithMetadataFromKV(mockKVNamespace, "abcd", undefined, 2)
-			).rejects.toThrowError(
-				"Requested asset abcd could not be fetched from KV namespace."
-			);
+			).rejects.toThrowError("KV GET abcd failed.");
 			expect(spy).toHaveBeenCalledTimes(3);
 		});
 
+		it("should inject message with error", async () => {
+			spy.mockReturnValue(
+				Promise.reject(new Error("Oeps! Something went wrong"))
+			);
+
+			await expect(() =>
+				getAssetWithMetadataFromKV(mockKVNamespace, "abcd")
+			).rejects.toThrowError("KV GET abcd failed: Oeps! Something went wrong");
+			expect(spy).toHaveBeenCalledTimes(2);
+		});
+
 		it("should retry on 404 and cache with 30s ttl", async () => {
 			let attempts = 0;
 			spy.mockImplementation(() => {