Skip to content

Commit fa36841

Browse files
skip e2e vite test on windows
1 parent a061a10 commit fa36841

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/vite-plugin-cloudflare/e2e/remote-bindings.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,11 @@ describe("remote bindings disabled", () => {
143143
const projectPath = seed("remote-bindings-disabled", "pnpm");
144144

145145
describe.each(commands)('with "%s" command', (command) => {
146-
test.skipIf(isBuildAndPreviewOnWindows(command))(
146+
// On Windows the path for the miniflare dependency gets pretty long and this fails in node < 22.7
147+
// (see: https://github.com/shellscape/jsx-email/issues/225#issuecomment-2420567832), so
148+
// we need to skip this on windows since in CI we're using node 20
149+
// we should look into re-enable this once we can move to a node a newer version of node
150+
test.skipIf(process.platform === "win32")(
147151
"cannot connect to remote bindings",
148152
async ({ expect }) => {
149153
const proc = await runLongLived("pnpm", command, projectPath);

0 commit comments

Comments
 (0)