feat: make provisioning non-interactive by default (#7884)

* flip default

* fix tests

* changeset

Author: emily-shen

.changeset/clean-carrots-draw.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+feat: make experiemntal auto-provisioning non-interactive by default.

packages/wrangler/e2e/provision.test.ts

@@ -67,9 +67,7 @@ describe("provisioning", { timeout: TIMEOUT }, () => {
 	});
 
 	it("can provision resources and deploy worker", async () => {
-		const worker = helper.runLongLived(
-			`wrangler deploy --x-provision --x-auto-create`
-		);
+		const worker = helper.runLongLived(`wrangler deploy --x-provision`);
 		await worker.exitCode;
 		const output = await worker.output;
 		expect(normalize(output)).toMatchInlineSnapshot(`

packages/wrangler/src/__tests__/provision.test.ts

@@ -92,7 +92,7 @@ describe("--x-provision", () => {
 			],
 		});
 
-		await runWrangler("deploy --x-provision");
+		await runWrangler("deploy --x-provision --x-auto-create=false");
 		expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
 				Worker Startup Time: 100 ms
@@ -176,7 +176,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -301,7 +301,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -436,7 +436,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -525,7 +525,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -583,7 +583,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
 				Worker Startup Time: 100 ms
@@ -650,7 +650,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -730,7 +730,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -800,7 +800,7 @@ describe("--x-provision", () => {
 				],
 			});
 
-			await runWrangler("deploy --x-provision");
+			await runWrangler("deploy --x-provision --x-auto-create=false");
 
 			expect(std.out).toMatchInlineSnapshot(`
 				"Total Upload: xx KiB / gzip: xx KiB
@@ -825,7 +825,9 @@ describe("--x-provision", () => {
 			legacy_env: false,
 			kv_namespaces: [{ binding: "KV" }],
 		});
-		await expect(runWrangler("deploy --x-provision")).rejects.toThrow(
+		await expect(
+			runWrangler("deploy --x-provision --x-auto-create=false")
+		).rejects.toThrow(
 			"Provisioning resources is not supported with a service environment"
 		);
 	});

packages/wrangler/src/deploy/index.ts

@@ -230,7 +230,7 @@ export function deployOptions(yargs: CommonYargsArgv) {
 			.option("experimental-auto-create", {
 				describe: "Automatically provision draft bindings with new resources",
 				type: "boolean",
-				default: false,
+				default: true,
 				hidden: true,
 				alias: "x-auto-create",
 			})