fix: ensure that wrangler deploy and version upload don't override the remote-bindings flag (#9673)

* fix: ensure that wrangler deploy and version upload don't override the remote-bindings flag

* add tests for wrangler deploy and version upload

Author: dario-piotrowicz

.changeset/better-rings-heal.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: ensure that wrangler deploy and version upload don't override the remote-bindings flag

packages/wrangler/src/__tests__/deploy.test.ts

@@ -13068,6 +13068,42 @@ export default{
 		});
 	});
 
+	it("should warn about unexpected experimental_remote fields", async () => {
+		writeWorkerSource();
+		writeWranglerConfig({
+			main: "./index.js",
+			kv_namespaces: [
+				{ binding: "MY_KV", id: "kv-id-xxx", experimental_remote: true },
+			],
+		});
+		mockSubDomainRequest();
+		mockUploadWorkerRequest();
+
+		await runWrangler("deploy");
+
+		expect(std.warn).toContain(
+			'Unexpected fields found in kv_namespaces[0] field: "experimental_remote"'
+		);
+	});
+
+	it("should not warn about experimental_remote fields when --x-remote-bindings is provided", async () => {
+		writeWorkerSource();
+		writeWranglerConfig({
+			main: "./index.js",
+			kv_namespaces: [
+				{ binding: "MY_KV", id: "kv-id-xxx", experimental_remote: true },
+			],
+		});
+		mockSubDomainRequest();
+		mockUploadWorkerRequest();
+
+		await runWrangler("deploy --x-remote-bindings");
+
+		expect(std.warn).not.toContain(
+			'Unexpected fields found in kv_namespaces[0] field: "experimental_remote"'
+		);
+	});
+
 	describe("multi-env warning", () => {
 		it("should warn if the wrangler config contains environments but none was specified in the command", async () => {
 			writeWorkerSource();

packages/wrangler/src/__tests__/versions/versions.upload.test.ts

@@ -211,6 +211,56 @@ describe("versions upload", () => {
 		expect(std.info).toContain("Retrying API call after error...");
 	});
 
+	it("should warn about unexpected experimental_remote fields", async () => {
+		mockGetScript();
+		mockUploadVersion(true);
+		mockGetWorkerSubdomain({ enabled: true, previews_enabled: false });
+
+		// Setup
+		writeWranglerConfig({
+			name: "test-name",
+			main: "./index.js",
+			kv_namespaces: [
+				{ binding: "MY_KV", id: "kv-id-xxx", experimental_remote: true },
+			],
+		});
+		writeWorkerSource();
+		setIsTTY(false);
+
+		const result = runWrangler("versions upload");
+
+		await expect(result).resolves.toBeUndefined();
+
+		expect(std.warn).toContain(
+			'Unexpected fields found in kv_namespaces[0] field: "experimental_remote"'
+		);
+	});
+
+	it("should not warn about experimental_remote fields when --x-remote-bindings is provided", async () => {
+		mockGetScript();
+		mockUploadVersion(true);
+		mockGetWorkerSubdomain({ enabled: true, previews_enabled: false });
+
+		// Setup
+		writeWranglerConfig({
+			name: "test-name",
+			main: "./index.js",
+			kv_namespaces: [
+				{ binding: "MY_KV", id: "kv-id-xxx", experimental_remote: true },
+			],
+		});
+		writeWorkerSource();
+		setIsTTY(false);
+
+		const result = runWrangler("versions upload --x-remote-bindings");
+
+		await expect(result).resolves.toBeUndefined();
+
+		expect(std.warn).not.toContain(
+			'Unexpected fields found in kv_namespaces[0] field: "experimental_remote"'
+		);
+	});
+
 	describe("multi-env warning", () => {
 		it("should warn if the wrangler config contains environments but none was specified in the command", async () => {
 			mockGetScript();

packages/wrangler/src/deploy/index.ts

@@ -220,7 +220,7 @@ export const deployCommand = createCommand({
 		overrideExperimentalFlags: (args) => ({
 			MULTIWORKER: false,
 			RESOURCES_PROVISION: args.experimentalProvision ?? false,
-			REMOTE_BINDINGS: false,
+			REMOTE_BINDINGS: args.experimentalRemoteBindings ?? false,
 		}),
 		warnIfMultipleEnvsConfiguredButNoneSpecified: true,
 	},

packages/wrangler/src/versions/upload.ts

@@ -264,7 +264,7 @@ export const versionsUploadCommand = createCommand({
 		overrideExperimentalFlags: (args) => ({
 			MULTIWORKER: false,
 			RESOURCES_PROVISION: args.experimentalProvision ?? false,
-			REMOTE_BINDINGS: false,
+			REMOTE_BINDINGS: args.experimentalRemoteBindings ?? false,
 		}),
 		warnIfMultipleEnvsConfiguredButNoneSpecified: true,
 	},