diff --git a/.changeset/three-toys-feel.md b/.changeset/three-toys-feel.md new file mode 100644 index 000000000000..0097ba311fc0 --- /dev/null +++ b/.changeset/three-toys-feel.md @@ -0,0 +1,5 @@ +--- +"wrangler": patch +--- + +fix: script should be accepted as a positional arg in the `versions upload` command diff --git a/packages/wrangler/src/__tests__/versions/versions.help.test.ts b/packages/wrangler/src/__tests__/versions/versions.help.test.ts index 8bacadf8879a..68e0deb64b99 100644 --- a/packages/wrangler/src/__tests__/versions/versions.help.test.ts +++ b/packages/wrangler/src/__tests__/versions/versions.help.test.ts @@ -18,7 +18,7 @@ describe("versions --help", () => { COMMANDS wrangler versions view View the details of a specific version of your Worker wrangler versions list List the 10 most recent Versions of your Worker - wrangler versions upload Uploads your Worker code and config as a new Version + wrangler versions upload [script] Uploads your Worker code and config as a new Version wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions wrangler versions secret Generate a secret that can be referenced in a Worker @@ -49,7 +49,7 @@ describe("versions subhelp", () => { COMMANDS wrangler versions view View the details of a specific version of your Worker wrangler versions list List the 10 most recent Versions of your Worker - wrangler versions upload Uploads your Worker code and config as a new Version + wrangler versions upload [script] Uploads your Worker code and config as a new Version wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions wrangler versions secret Generate a secret that can be referenced in a Worker diff --git a/packages/wrangler/src/__tests__/versions/versions.upload.test.ts b/packages/wrangler/src/__tests__/versions/versions.upload.test.ts index e6c557ad5053..f622948afc12 100644 --- a/packages/wrangler/src/__tests__/versions/versions.upload.test.ts +++ b/packages/wrangler/src/__tests__/versions/versions.upload.test.ts @@ -109,6 +109,32 @@ describe("versions upload", () => { `); }); + test("should accept script as a positional arg", async () => { + mockGetScript(); + mockUploadVersion(false); + + // Setup + writeWranglerConfig({ + name: "test-name", + // i.e. would error if the arg wasn't picked up + main: "./nope.js", + }); + writeWorkerSource(); + setIsTTY(false); + + const result = runWrangler("versions upload index.js"); + + await expect(result).resolves.toBeUndefined(); + + expect(std.out).toMatchInlineSnapshot(` + "Total Upload: xx KiB / gzip: xx KiB + Worker Startup Time: 500 ms + No bindings found. + Uploaded test-name (TIMINGS) + Worker Version ID: 51e4886e-2db7-4900-8d38-fbfecfeab993" + `); + }); + test("should print preview url if version has preview", async () => { mockGetScript(); mockUploadVersion(true); diff --git a/packages/wrangler/src/versions/upload.ts b/packages/wrangler/src/versions/upload.ts index 8eaea4a7d80c..47398870bc3a 100644 --- a/packages/wrangler/src/versions/upload.ts +++ b/packages/wrangler/src/versions/upload.ts @@ -96,6 +96,7 @@ export const versionsUploadCommand = createCommand({ owner: "Workers: Authoring and Testing", status: "stable", }, + positionalArgs: ["script"], args: { script: { describe: "The path to an entry point for your Worker",