Wrangler preview urls e2e fixes and warning follow up #10561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 96768ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
for-the-kidz
approved these changes
Sep 5, 2025
danielrs
changed the title
Contributor
That sounds bad! What the initial PR merged with failing E2E? |
Contributor
Author
Seems like it was somehow skipped? Just fixed some snapshot lines. |
edmundhung
reviewed
Sep 8, 2025
danielrs
force-pushed
the
drivas/wrangler-preview-urls-default-follow-up
branch
2 times, most recently
from
3d6d9c2 to
58bc92b
Compare
danielrs
force-pushed
the
drivas/wrangler-preview-urls-default-follow-up
branch
from
58bc92b to
8c2bbfa
Compare
petebacondarwin
force-pushed
the
drivas/wrangler-preview-urls-default-follow-up
branch
from
8c2bbfa to
d007e1e
Compare
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
You ticked that this PR doesn't need a backport because it is "not a new feature". But patches to current features are exactly what does need backporting. The only reason this might not be backported is if the feature being patched is not in Wrangler v3. Is that the case?
danielrs
force-pushed
the
drivas/wrangler-preview-urls-default-follow-up
branch
3 times, most recently
from
6d5f22a to
c590603
Compare
dario-piotrowicz
added
the
skip-v3-pr
petebacondarwin
approved these changes
Sep 17, 2025
6 tasks
…g to false Fixes existing tests, and adds a new test for `preview_urls = true`.
…st deploy These warnings are just noise on a first deploy, not really necessary.
danielrs
force-pushed
the
drivas/wrangler-preview-urls-default-follow-up
branch
from
3bc4b62 to
96768ea
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of: #10478
Describe your change...