Skip to content

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 10, 2025

Fixes DEVX-1834

Unflag remote bindings


@penalosa penalosa requested review from a team as code owners September 10, 2025 17:05
@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: b2ff620

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Minor
@cloudflare/vite-plugin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 10, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10604

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10604

miniflare

npm i https://pkg.pr.new/miniflare@10604

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10604

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10604

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10604

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10604

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10604

wrangler

npm i https://pkg.pr.new/wrangler@10604

commit: b2ff620

@lrapoport-cf
Copy link
Contributor

Documentation not necessary because: tracked elsewhere

is there a docs PR? we'll want to update https://developers.cloudflare.com/workers/development-testing/#remote-bindings

poolOptions: {
workers: {
experimental_remoteBindings: true,
remoteBindings: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this field still supposed to be here? in vitest.workers.config.ts it's removed entirely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No—removed now

@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Sep 11, 2025
)
: undefined;
const remoteProxySessionData =
resolvedPluginConfig.experimental.remoteBindings ?? true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this experimental property still valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see #10604 (comment)

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 11, 2025
@penalosa penalosa requested a review from a team as a code owner September 11, 2025 20:00
@penalosa penalosa merged commit 135e066 into main Sep 11, 2025
31 checks passed
@penalosa penalosa deleted the penalosa/stable-remote-bindings branch September 11, 2025 21:11
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 11, 2025
@zalmanlew
Copy link

zalmanlew commented Sep 12, 2025

With this change, how can I leave my bindings as remote-able and still run it locally?

Previously I could run as-is for local, and with --x-remote-bindings to enable remote

With this change, even if I run wrangler dev --local it still connects to remote bindings

the remote: true in the wrangler seems to not be overwritten by --local flag

@penalosa
Copy link
Contributor Author

@zalmanlew The intention is that you'd remove remote: true for any bindings you don't want to be remote

@zalmanlew
Copy link

@penalosa I keep two scripts in my package.json to easily switch between running locally (default) or using remote bindings for specific debugging.

"dev": "wrangler dev -e=dev",
"dev:remote": "wrangler dev -e=dev --x-remote-bindings"

or in the new version

"dev": "wrangler dev -e=dev --local",
"dev:remote": "wrangler dev -e=dev"

In general if the user adds --local flag that should probably overwrite any remote settings from wrangler.jsonc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants