-
Notifications
You must be signed in to change notification settings - Fork 1k
Unflag remote bindings #10604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unflag remote bindings #10604
Conversation
🦋 Changeset detectedLatest commit: b2ff620 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
is there a docs PR? we'll want to update https://developers.cloudflare.com/workers/development-testing/#remote-bindings |
| poolOptions: { | ||
| workers: { | ||
| experimental_remoteBindings: true, | ||
| remoteBindings: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this field still supposed to be here? in vitest.workers.config.ts it's removed entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No—removed now
Updated package versions to minor and enabled remote bindings without the flag.
| ) | ||
| : undefined; | ||
| const remoteProxySessionData = | ||
| resolvedPluginConfig.experimental.remoteBindings ?? true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this experimental property still valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see #10604 (comment)
|
With this change, how can I leave my bindings as remote-able and still run it locally? Previously I could run as-is for local, and with With this change, even if I run the |
|
@zalmanlew The intention is that you'd remove |
|
@penalosa I keep two scripts in my "dev": "wrangler dev -e=dev",
"dev:remote": "wrangler dev -e=dev --x-remote-bindings"or in the new version "dev": "wrangler dev -e=dev --local",
"dev:remote": "wrangler dev -e=dev"In general if the user adds |
Fixes DEVX-1834
Unflag remote bindings