Skip to content

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 15, 2025

Fixes #10635

When the --local flag is provided, turn off remote bindings.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a v3 feature

@penalosa penalosa requested a review from a team as a code owner September 15, 2025 15:18
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: 11d81a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 15, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10657

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10657

miniflare

npm i https://pkg.pr.new/miniflare@10657

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10657

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10657

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10657

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10657

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10657

wrangler

npm i https://pkg.pr.new/wrangler@10657

commit: 11d81a6

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You probably want to add a changeset file.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 15, 2025
This change disables remote bindings when using the --local flag.
@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/remote-bindings-local might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10657
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Sep 15, 2025
@penalosa penalosa merged commit 31ec996 into main Sep 15, 2025
40 of 44 checks passed
@penalosa penalosa deleted the penalosa/remote-bindings-local branch September 15, 2025 16:47
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 15, 2025
@zalmanlew
Copy link

I just tested this on the latest release (4.37.1) and it's not applying the --local flag

image

@penalosa
Copy link
Contributor Author

@zalmanlew I think that's just a bug in the bindings display—the actual bindings should be local. We'll get the display bug fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

--local flag should override remote:true to use local bindings

3 participants