Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Sep 17, 2025

We have this PR which windows test always either errors because of flakes or times out because of the 30 minutes limit: #10561

Screenshot 2025-09-17 at 18 17 28

So I am increasing the limit to 45 minutes hoping that this will enable the PR's workflow to pass

Note: 45 is the same time limit we have for the c3 e2es:

timeout-minutes: 45


  • Tests
    • Tests included
    • Tests not necessary because: infra change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: infra change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: infra change

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner September 17, 2025 17:16
@dario-piotrowicz dario-piotrowicz added no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR labels Sep 17, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 46ae6c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 17, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10688

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10688

miniflare

npm i https://pkg.pr.new/miniflare@10688

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10688

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10688

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10688

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10688

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10688

wrangler

npm i https://pkg.pr.new/wrangler@10688

commit: 46ae6c3

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 17, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/increase-tests-timeout-to-40 branch from 74a8b39 to 46ae6c3 Compare September 17, 2025 17:21
@dario-piotrowicz dario-piotrowicz changed the title increase tests timeout to 40 minutes increase tests timeout to 45 minutes Sep 17, 2025
@dario-piotrowicz dario-piotrowicz merged commit ab26bcd into main Sep 17, 2025
29 of 32 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/increase-tests-timeout-to-40 branch September 17, 2025 17:34
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants