Add find_additional_modules option to support partial bundling with externals

[petebacondarwin]

Disclaimer - WIP and untested!

This fairly chunky branch contains code that should allow us to search for rules matching modules when also bundling Workers.

Hey! 👋 This should be good to go now, see #3726 (comment) for details.

[changeset-bot]

🦋 Changeset detected

Latest commit: cce3d79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6418496031/npm-package-wrangler-3726

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6418496031/npm-package-wrangler-3726

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6418496031/npm-package-wrangler-3726 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6418496031/npm-package-cloudflare-pages-shared-3726

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	3.20231002.0	3.20231002.0
workerd	1.20231002.0	1.20231002.0
workerd --version	1.20231002.0	2023-10-02

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Merging #3726 (cce3d79) into main (5fc7a88) will increase coverage by 0.23%.
The diff coverage is 86.61%.

@@            Coverage Diff             @@
##             main    #3726      +/-   ##
==========================================
+ Coverage   75.09%   75.32%   +0.23%     
==========================================
  Files         217      222       +5     
  Lines       12077    12179     +102     
  Branches     3128     3149      +21     
==========================================
+ Hits         9069     9174     +105     
+ Misses       3008     3005       -3     

Files	Coverage Δ
packages/wrangler/src/api/pages/deploy.tsx	86.15% <ø> (ø)
packages/wrangler/src/config/validation.ts	90.03% <ø> (ø)
packages/wrangler/src/deploy/deploy.ts	87.90% <100.00%> (+0.31%)	⬆️
...wrangler/src/deployment-bundle/apply-middleware.ts	100.00% <100.00%> (ø)
...s/wrangler/src/deployment-bundle/build-failures.ts	100.00% <100.00%> (ø)
...ages/wrangler/src/deployment-bundle/bundle-type.ts	100.00% <100.00%> (ø)
...src/deployment-bundle/create-worker-upload-form.ts	89.85% <100.00%> (+1.05%)	⬆️
...s/wrangler/src/deployment-bundle/dedupe-modules.ts	100.00% <100.00%> (ø)
packages/wrangler/src/deployment-bundle/rules.ts	100.00% <100.00%> (ø)
packages/wrangler/src/dev.tsx	83.53% <ø> (ø)
... and 17 more

... and 3 files with indirect coverage changes

[mrbbot]

Hey! 👋 I think this PR is ready to go now (minus some docs). You can now add something like...

find_additional_modules = true
rules = [
  { type = "ESModule", globs = ["**/*.js"]},
]

...to your wrangler.toml file, and have Wrangler bundle your entrypoint as usual, but upload all *.js files as is, marking them external. Appropriate files are watched in wrangler dev to trigger rebuilds when files are changed/created.

This gives us a slightly nicer "no bundle" mode, with the ability to use middleware whilst maintaining lazy loading/dynamic imports of --no-bundle mode.

Note, find_additional_modules is disabled when using service workers as it relies on the ability to pass multiple modules to the runtime, which isn't supported with service worker scripts.

Closes #3074

[mrbbot]

Blocked by cloudflare/miniflare#631

[dario-piotrowicz]

Confirming that this works and it's making the new lazy loading implementation of the workers nuxt adapter work 😃 🚀 🎉

See https://nuxt-split-workers-test.devdash.workers.dev/ (source)

[dario-piotrowicz]

Look good to me 😃

I gave the PR a somewhat thorough read and it looks all good to me, but I am very very unfamiliar with the codebase so this for sure still needs to be reviewed by someone much much more familiar with it than me

Note
This requires #3799 in order to work

[irvinebroque]

Is there context on why we added this but didn't put in dev docs?

[petebacondarwin]

Is there context on why we added this but didn't put in dev docs?

An oversight on my part, or at least I got pulled onto other stuff and it fell off my radar; on top of that it was mainly designed for advanced users who kind of know the code already. But I think it is worth documenting this now.

[petebacondarwin]

cloudflare/cloudflare-docs#17524