[DO NOT MERGE] MQ-667: add queues update sub command #6450

TaraGarg · 2024-08-08T18:24:16Z

What this PR solves / how to test

Fixes https://jira.cfdata.org/browse/MQ-667

Author has addressed the following

Tests
- TODO (before merge)
- Included
- Not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required / Maybe required
- Not required because:
Changeset (Changeset guidelines)
- TODO (before merge)
- Included
- Not necessary because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): Updated documentation to include commands to update a queue, and set retention period cloudflare-docs#16080
- Not necessary because:

changeset-bot · 2024-08-08T18:24:20Z

🦋 Changeset detected

Latest commit: b56321b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-08-08T18:26:34Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-wrangler-6450

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6450/npm-package-wrangler-6450

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-wrangler-6450 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-create-cloudflare-6450 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-kv-asset-handler-6450

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-miniflare-6450

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-pages-shared-6450

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-vitest-pool-workers-6450

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-workers-editor-shared-6450

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-workers-shared-6450

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20240806.0
`workerd`	1.20240806.0	1.20240806.0
`workerd --version`	1.20240806.0	2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

.changeset/wet-grapes-vanish.md

petebacondarwin · 2024-08-12T19:34:36Z

packages/wrangler/src/queues/client.ts

+): Promise<QueueResponse> {
+	const accountId = await requireAuth(config);
+	return fetchResult(queuesUrl(accountId, queue_id), {
+		method: "PUT", // TODO: PATCH


w-kuhn

can update this to use the PATCH endpoint once it is merged & released

.changeset/wet-grapes-vanish.md

petebacondarwin · 2024-08-13T15:31:38Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

w-kuhn · 2024-08-13T17:56:23Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

Co-authored-by: Pete Bacon Darwin <[email protected]>

packages/wrangler/src/queues/cli/commands/update.ts

packages/wrangler/src/__tests__/queues.test.ts

CarmenPopoviciu · 2024-08-15T07:11:50Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

w-kuhn · 2024-08-15T11:10:25Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

This PR should land asap. Updating to use the new endpoint should happen as a fast follow.

w-kuhn · 2024-08-15T11:13:35Z

can update this to use the PATCH endpoint once it is merged & released

But don't block this PR on that.

TaraGarg · 2024-08-15T15:32:19Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

We are now waiting to make message expiration for queues available to everyone before we merge these wrangler CLI changes since we don't have something like a gate to only allow certain accounts in the workers-sdk changes.

CarmenPopoviciu · 2024-08-15T16:29:03Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

We are now waiting to make message expiration for queues available to everyone before we merge these wrangler CLI changes since we don't have something like a gate to only allow certain accounts in the workers-sdk changes.

@TaraGarg so should I hold off merging these changes?

TaraGarg · 2024-08-15T16:33:19Z

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

We are now waiting to make message expiration for queues available to everyone before we merge these wrangler CLI changes since we don't have something like a gate to only allow certain accounts in the workers-sdk changes.

@TaraGarg so should I hold off merging these changes?

Yes please!

penalosa · 2024-11-12T23:58:33Z

Sounds like this is not ready to go, so moving to draft

sdnts · 2025-02-12T19:52:57Z

Rebased and opened up a new PR here: #8120
This one can be closed (I don't have permissions to do that)

MQ-667: add queues update sub command

a098691

TaraGarg requested a review from a team as a code owner August 8, 2024 18:24

tgarg-cf added 5 commits August 8, 2024 14:48

fix breaking tests

d6e8e4a

fix breaking tests 2

16db2ad

fix formatting

4d9cd00

MQ-667: add bounds check for delivery delay and message retention period

92fa0dd

MQ-667: fixed tests

43922ee

maheshwarip mentioned this pull request Aug 12, 2024

Updated documentation to include commands to update a queue, and set retention period cloudflare/cloudflare-docs#16080

Closed

petebacondarwin requested changes Aug 12, 2024

View reviewed changes

w-kuhn approved these changes Aug 13, 2024

View reviewed changes

TaraGarg requested a review from petebacondarwin August 13, 2024 15:15

petebacondarwin requested changes Aug 13, 2024

View reviewed changes

.changeset/wet-grapes-vanish.md Outdated Show resolved Hide resolved

TaraGarg requested a review from petebacondarwin August 13, 2024 18:54

Update .changeset/wet-grapes-vanish.md

d5ded4b

Co-authored-by: Pete Bacon Darwin <[email protected]>

CarmenPopoviciu reviewed Aug 15, 2024

View reviewed changes

packages/wrangler/src/queues/cli/commands/update.ts Show resolved Hide resolved

CarmenPopoviciu reviewed Aug 15, 2024

View reviewed changes

packages/wrangler/src/__tests__/queues.test.ts Show resolved Hide resolved

CarmenPopoviciu added the awaiting reporter response Needs clarification or followup from OP label Aug 15, 2024

added tests to check invalid input

b56321b

CarmenPopoviciu removed the awaiting reporter response Needs clarification or followup from OP label Aug 15, 2024

CarmenPopoviciu changed the title ~~MQ-667: add queues update sub command~~ [DO NOT MERGE] MQ-667: add queues update sub command Aug 15, 2024

penalosa marked this pull request as draft November 12, 2024 23:58

penalosa closed this Jul 15, 2025

github-project-automation bot moved this from In Review to Done in workers-sdk Jul 15, 2025

[DO NOT MERGE] MQ-667: add queues update sub command #6450

[DO NOT MERGE] MQ-667: add queues update sub command #6450

Conversation

TaraGarg commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR solves / how to test

Author has addressed the following

Uh oh!

changeset-bot bot commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

petebacondarwin Aug 12, 2024

Choose a reason for hiding this comment

Uh oh!

w-kuhn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

petebacondarwin commented Aug 13, 2024

Uh oh!

w-kuhn commented Aug 13, 2024

Uh oh!

Uh oh!

Uh oh!

CarmenPopoviciu commented Aug 15, 2024

Uh oh!

w-kuhn commented Aug 15, 2024

Uh oh!

w-kuhn commented Aug 15, 2024

Uh oh!

TaraGarg commented Aug 15, 2024

Uh oh!

CarmenPopoviciu commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaraGarg commented Aug 15, 2024

Uh oh!

penalosa commented Nov 12, 2024

Uh oh!

sdnts commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TaraGarg commented Aug 8, 2024 •

edited

Loading

changeset-bot bot commented Aug 8, 2024 •

edited

Loading

github-actions bot commented Aug 8, 2024 •

edited

Loading

CarmenPopoviciu commented Aug 15, 2024 •

edited

Loading

sdnts commented Feb 12, 2025 •

edited

Loading