Add set and range filters to filter validation when using Wrangler CLI #7592
+40
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32bb52d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-wrangler-7592You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7592/npm-package-wrangler-7592Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-wrangler-7592 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-workers-bindings-extension-7592 -O ./cloudflare-workers-bindings-extension.0.0.0-v72c6f3e70.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v72c6f3e70.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-create-cloudflare-7592 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-kv-asset-handler-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-miniflare-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-pages-shared-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-unenv-preset-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-vitest-pool-workers-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-workers-editor-shared-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-workers-shared-7592npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12659788504/npm-package-cloudflare-workflows-shared-7592Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
garvit-gupta
approved these changes
Dec 19, 2024
Contributor
garvit-gupta
left a comment
garvit-gupta
left a comment
There was a problem hiding this comment.
Logic seems sound. Should be good to go once the github actions comments are resolved and a changeset is added.
garrettgu10
force-pushed
the
ggu/vectorize-in-nin-range-filter-validation
branch
from
556f57d to
e63254e
Compare
garvit-gupta
approved these changes
Dec 20, 2024
garrettgu10
force-pushed
the
ggu/vectorize-in-nin-range-filter-validation
branch
from
e63254e to
7bd6861
Compare
penalosa
approved these changes
Jan 7, 2025
garrettgu10
force-pushed
the
ggu/vectorize-in-nin-range-filter-validation
branch
from
7bd6861 to
32224e0
Compare
Merged
penalosa
pushed a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing Vectorize query operations through the wrangler CLI, this PR makes it so that the filter validation logic is able to accept filters involving set ($in or $nin) or range(e.g. $lte) queries.