chore: graduate hello world workers + assets templates #8379

emily-shen · 2025-03-06T15:27:55Z

Fixes DEVX-1729

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: existing tests
Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): Update c3 hello world labels cloudflare-docs#20627
- Documentation not necessary because:

changeset-bot · 2025-03-06T15:27:59Z

🦋 Changeset detected

Latest commit: ca8f275

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

emily-shen · 2025-03-06T15:29:21Z

packages/create-cloudflare/src/helpers/cli.ts

 	projectName: new Haikunator().haikunate({ tokenHex: true }),
 	category: "hello-world",
-	type: "hello-world",
+	type: "hello-world-with-assets",


changed the default to worker + assets

Is it weird for the default to be in the middle of the list? is this list too many options?

works for me.

github-actions · 2025-03-06T16:10:16Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-wrangler-8379

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8379/npm-package-wrangler-8379

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-wrangler-8379 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-workers-bindings-extension-8379 -O ./cloudflare-workers-bindings-extension.0.0.0-v6f55cb5c7.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v6f55cb5c7.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-create-cloudflare-8379 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-kv-asset-handler-8379

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-miniflare-8379

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-pages-shared-8379

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-unenv-preset-8379

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-vite-plugin-8379

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-vitest-pool-workers-8379

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-workers-editor-shared-8379

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-workers-shared-8379

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13865290493/npm-package-cloudflare-workflows-shared-8379

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	4.20250310.0
`workerd`	1.20250310.0	1.20250310.0
`workerd --version`	1.20250310.0	2025-03-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

emily-shen · 2025-03-06T21:31:24Z

packages/create-cloudflare/e2e-tests/cli.test.ts

 				expect(project.path).toExist();
 				expect(output).toContain(`type Scheduled Worker (Cron Trigger)`);
 				expect(output).toContain(`lang JavaScript`);
-				expect(output).toContain(`no git`);


Not sure why this is failing now - I would've expected this to start failing after #8290. This question definitely isn't there if you pass in --no-git on c3 latest, so it's not a result of this PR. Were the tests just cached all that time? 😬

Perhaps because these tests were skipped in experimental mode?

describe.skipIf(experimental || ...

but the no git thing applies regardless of whether experimental, so they should have have been failing in the experimental:false runs too 🤔

petebacondarwin

LGTM!

petebacondarwin · 2025-03-07T13:54:14Z

packages/create-cloudflare/e2e-tests/cli.test.ts

 				expect(project.path).toExist();
 				expect(output).toContain(`type Scheduled Worker (Cron Trigger)`);
 				expect(output).toContain(`lang JavaScript`);
-				expect(output).toContain(`no git`);


Perhaps because these tests were skipped in experimental mode?

describe.skipIf(experimental || ...

petebacondarwin · 2025-03-07T13:55:06Z

packages/create-cloudflare/e2e-tests/workers.test.ts


 function getWorkerTests(opts: { experimental: boolean }): WorkerTestConfig[] {
 	if (opts.experimental) {
+		// none currently


petebacondarwin · 2025-03-07T13:56:16Z

packages/create-cloudflare/src/helpers/cli.ts

 	projectName: new Haikunator().haikunate({ tokenHex: true }),
 	category: "hello-world",
-	type: "hello-world",
+	type: "hello-world-with-assets",


works for me.

vy-ton · 2025-03-19T19:36:05Z

@emily-shen @korinne Can we make sure any Asset examples with DOs use new_sqlite_classes?

This PR was after #8460 so we didnt catch the new c3 templates.

emily-shen requested a review from a team as a code owner March 6, 2025 15:27

emily-shen requested a review from a team March 6, 2025 15:27

emily-shen commented Mar 6, 2025

View reviewed changes

workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Mar 6, 2025

emily-shen force-pushed the emily/graduate-assets-hello-world branch from c7fa27a to e31239c Compare March 6, 2025 15:46

workers-devprod added this to workers-sdk Mar 6, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Mar 6, 2025

emily-shen added the e2e Run wrangler + vite-plugin e2e tests on a PR label Mar 6, 2025

emily-shen commented Mar 6, 2025

View reviewed changes

petebacondarwin force-pushed the emily/graduate-assets-hello-world branch from e04363c to ac2ae06 Compare March 7, 2025 13:50

petebacondarwin approved these changes Mar 7, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 7, 2025

emily-shen mentioned this pull request Mar 7, 2025

Update c3 hello world labels cloudflare/cloudflare-docs#20627

Merged

emily-shen force-pushed the emily/graduate-assets-hello-world branch 2 times, most recently from 47df992 to 4a88cc9 Compare March 7, 2025 17:37

emily-shen added 7 commits March 13, 2025 14:50

graduate hello world workers assets templates

a638860

changeset

ccdf6d0

fix tests

5ec0524

maybe fix tests

66d8336

update labels

da1fbb3

fix test

ffbaddf

update c3-integration test

ca8f275

emily-shen force-pushed the emily/graduate-assets-hello-world branch from 0eec308 to ca8f275 Compare March 13, 2025 14:50

Merge branch 'main' into emily/graduate-assets-hello-world

eec9565

emily-shen merged commit 2b37abe into main Mar 18, 2025
32 of 33 checks passed

github-project-automation bot moved this from Approved to Done in workers-sdk Mar 18, 2025

emily-shen deleted the emily/graduate-assets-hello-world branch March 18, 2025 11:09

workers-devprod mentioned this pull request Mar 18, 2025

Version Packages #8540

Merged

emily-shen mentioned this pull request Mar 19, 2025

@emily-shen @korinne Can we make sure any Asset examples with DOs use new_sqlite_classes? #8585

Closed

chore: graduate hello world workers + assets templates #8379

chore: graduate hello world workers + assets templates #8379

Uh oh!

Conversation

emily-shen commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

emily-shen Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emily-shen Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

emily-shen Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vy-ton commented Mar 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emily-shen commented Mar 6, 2025 •

edited

Loading

changeset-bot bot commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

emily-shen Mar 6, 2025 •

edited

Loading