-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: graduate hello world workers + assets templates #8379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a638860
graduate hello world workers assets templates
emily-shen ccdf6d0
changeset
emily-shen 5ec0524
fix tests
emily-shen 66d8336
maybe fix tests
emily-shen da1fbb3
update labels
emily-shen ffbaddf
fix test
emily-shen ca8f275
update c3-integration test
emily-shen eec9565
Merge branch 'main' into emily/graduate-assets-hello-world
emily-shen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "create-cloudflare": patch | ||
| --- | ||
|
|
||
| Graduate Workers + Assets hello world templates from experimental status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,35 @@ type WorkerTestConfig = RunnerConfig & { | |
|
|
||
| function getWorkerTests(opts: { experimental: boolean }): WorkerTestConfig[] { | ||
| if (opts.experimental) { | ||
| // none currently | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 |
||
| return []; | ||
| } else { | ||
| return [ | ||
| { | ||
| template: "hello-world", | ||
| variants: ["ts", "js"], | ||
| verifyDeploy: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| verifyPreview: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| verifyTest: true, | ||
| }, | ||
| { | ||
| template: "hello-world", | ||
| variants: ["python"], | ||
| verifyDeploy: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| verifyPreview: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| }, | ||
| { | ||
| template: "hello-world-with-assets", | ||
| variants: ["ts", "js"], | ||
|
|
@@ -78,34 +106,6 @@ function getWorkerTests(opts: { experimental: boolean }): WorkerTestConfig[] { | |
| verifyPreview: null, | ||
| argv: ["--category", "hello-world"], | ||
| }, | ||
| ]; | ||
| } else { | ||
| return [ | ||
| { | ||
| template: "hello-world", | ||
| variants: ["ts", "js"], | ||
| verifyDeploy: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| verifyPreview: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| verifyTest: true, | ||
| }, | ||
| { | ||
| template: "hello-world", | ||
| variants: ["python"], | ||
| verifyDeploy: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| verifyPreview: { | ||
| route: "/", | ||
| expectedText: "Hello World!", | ||
| }, | ||
| }, | ||
| { | ||
| template: "common", | ||
| variants: ["ts", "js"], | ||
|
|
@@ -155,6 +155,7 @@ describe | |
| .skipIf( | ||
| getFrameworkToTest({ experimental }) || | ||
| isQuarantineMode() || | ||
| workerTests.length === 0 || | ||
| process.platform === "win32", | ||
| ) | ||
| .concurrent(`E2E: Workers templates`, () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,7 +48,7 @@ export const isUpdateAvailable = async () => { | |
| export const C3_DEFAULTS: C3Args = { | ||
| projectName: new Haikunator().haikunate({ tokenHex: true }), | ||
| category: "hello-world", | ||
| type: "hello-world", | ||
| type: "hello-world-with-assets", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. works for me. |
||
| framework: "analog", | ||
| experimental: false, | ||
| autoUpdate: true, | ||
|
|
@@ -57,11 +57,11 @@ export const C3_DEFAULTS: C3Args = { | |
| open: true, | ||
| lang: "ts", | ||
| template: | ||
| "cloudflare/workers-sdk/packages/create-cloudflare/templates/hello-world", | ||
| "cloudflare/workers-sdk/packages/create-cloudflare/templates/hello-world-with-assets", | ||
| }; | ||
|
|
||
| export const WRANGLER_DEFAULTS = { | ||
| ...C3_DEFAULTS, | ||
| type: "hello-world", | ||
| type: "hello-world-with-assets", | ||
| deploy: false, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
packages/create-cloudflare/templates/hello-world-durable-object/c3.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
...xperimental/hello-world-with-assets/c3.ts → ...e/templates/hello-world-with-assets/c3.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is failing now - I would've expected this to start failing after #8290. This question definitely isn't there if you pass in --no-git on c3 latest, so it's not a result of this PR. Were the tests just cached all that time? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps because these tests were skipped in experimental mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the no git thing applies regardless of whether experimental, so they should have have been failing in the experimental:false runs too 🤔