-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add bulk gets for kv in miniflare #8623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bulk gets for kv in miniflare #8623
Conversation
🦋 Changeset detectedLatest commit: 174773e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-wrangler-8623You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8623/npm-package-wrangler-8623Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-wrangler-8623 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workers-bindings-extension-8623 -O ./cloudflare-workers-bindings-extension.0.0.0-v461cd1bfb.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v461cd1bfb.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-create-cloudflare-8623 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-kv-asset-handler-8623miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-miniflare-8623@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-pages-shared-8623@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-unenv-preset-8623@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-vite-plugin-8623@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-vitest-pool-workers-8623@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workers-editor-shared-8623@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workers-shared-8623@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workflows-shared-8623Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
|
@teresalves this will need to rebase on main to pull in the latest workerd |
da807de to
7196c85
Compare
7196c85 to
3cfb2d0
Compare
49f4f55 to
16ec028
Compare
6e07018 to
816169b
Compare
|
could we please get a KV approval on this PR 🙏 ? |
rts-rob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as is; we will do a fast follow to tighten up some documentation.
37ecbb0 to
4ff4fa4
Compare
4ff4fa4 to
e0b46e8
Compare
CarmenPopoviciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work on this 🚀
Fixes KV-1435
Adding new feature for bulk gets in miniflare.
It has already been added in workerd.
We are injecting a timestamp when we read/write our keys. So
key1becomes1742848988250_122630884213439key1. This never influenced our tests because we never got the key back, and since the keys always matched in the write and read, it didn't matter. Now we had to clean that up when returning it back to the test result.CR-1140001