Skip to content

Conversation

@teresalves
Copy link
Contributor

@teresalves teresalves commented Mar 21, 2025

Fixes KV-1435
Adding new feature for bulk gets in miniflare.
It has already been added in workerd.

We are injecting a timestamp when we read/write our keys. So key1 becomes 1742848988250_122630884213439key1. This never influenced our tests because we never got the key back, and since the keys always matched in the write and read, it didn't matter. Now we had to clean that up when returning it back to the test result.

CR-1140001


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: We are just adding a new component in miniflare.
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: adds new feature

@teresalves teresalves requested a review from a team as a code owner March 21, 2025 14:08
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: 174773e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-wrangler-8623

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8623/npm-package-wrangler-8623

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-wrangler-8623 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workers-bindings-extension-8623 -O ./cloudflare-workers-bindings-extension.0.0.0-v461cd1bfb.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v461cd1bfb.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-create-cloudflare-8623 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-kv-asset-handler-8623

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-miniflare-8623

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-pages-shared-8623

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-unenv-preset-8623

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-vite-plugin-8623

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-vitest-pool-workers-8623

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workers-editor-shared-8623

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workers-shared-8623

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14108117783/npm-package-cloudflare-workflows-shared-8623

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.0
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa
Copy link
Contributor

@teresalves this will need to rebase on main to pull in the latest workerd

@teresalves teresalves marked this pull request as draft March 21, 2025 15:30
@teresalves teresalves force-pushed the teresalves/add-bulk-gets-for-kv branch 2 times, most recently from da807de to 7196c85 Compare March 25, 2025 16:14
@teresalves teresalves force-pushed the teresalves/add-bulk-gets-for-kv branch from 7196c85 to 3cfb2d0 Compare March 25, 2025 16:19
@teresalves teresalves marked this pull request as ready for review March 25, 2025 16:33
@teresalves teresalves force-pushed the teresalves/add-bulk-gets-for-kv branch from 49f4f55 to 16ec028 Compare March 25, 2025 17:08
@teresalves teresalves force-pushed the teresalves/add-bulk-gets-for-kv branch from 6e07018 to 816169b Compare March 26, 2025 15:56
@CarmenPopoviciu
Copy link
Contributor

could we please get a KV approval on this PR 🙏 ?

@rts-rob rts-rob self-requested a review March 27, 2025 10:05
Copy link
Contributor

@rts-rob rts-rob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is; we will do a fast follow to tighten up some documentation.

@teresalves teresalves requested a review from a team as a code owner March 27, 2025 10:28
@teresalves teresalves force-pushed the teresalves/add-bulk-gets-for-kv branch 2 times, most recently from 37ecbb0 to 4ff4fa4 Compare March 27, 2025 12:57
@teresalves teresalves force-pushed the teresalves/add-bulk-gets-for-kv branch from 4ff4fa4 to e0b46e8 Compare March 27, 2025 13:00
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on this 🚀

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 27, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit cad99dc into cloudflare:main Mar 27, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants