Skip to content

V3 Backport #8697: prevent getPlatformProxy from crashing with internal DOs #8713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 1, 2025
Merged

V3 Backport #8697: prevent getPlatformProxy from crashing with internal DOs #8713

merged 14 commits into from
Apr 1, 2025

Conversation

@CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Mar 28, 2025

This is a manually opened PR to backport patch changes from #8697 to Wrangler v3

@CarmenPopoviciu CarmenPopoviciu added skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR labels Mar 28, 2025
@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner March 28, 2025 12:23
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ecae6dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CarmenPopoviciu CarmenPopoviciu mentioned this pull request Mar 28, 2025
Merged
12 tasks
@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Mar 28, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-wrangler-8713

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8713/npm-package-wrangler-8713

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-wrangler-8713 dev path/to/script.js
Additional artifacts:

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-cloudflare-kv-asset-handler-8713

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-miniflare-8713

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-cloudflare-pages-shared-8713

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-cloudflare-unenv-preset-8713

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-cloudflare-workers-shared-8713

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14175063723/npm-package-cloudflare-workflows-shared-8713

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250310.1
workerd 1.20250310.0 1.20250310.0
workerd --version 1.20250310.0 2025-03-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

emily-shen
emily-shen approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending the docs link update here as well :)

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 28, 2025
@CarmenPopoviciu CarmenPopoviciu changed the title fix(wrangler): prevent getPlatformProxy from crashing with internal DOs V3 Backport: prevent getPlatformProxy from crashing with internal DOs Mar 28, 2025
@CarmenPopoviciu CarmenPopoviciu changed the title V3 Backport: prevent getPlatformProxy from crashing with internal DOs V3 Backport #8697: prevent getPlatformProxy from crashing with internal DOs Mar 28, 2025
@CarmenPopoviciu CarmenPopoviciu added blocked Blocked on other work and removed blocked Blocked on other work labels Mar 28, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit 47bf369 into v3-maintenance Apr 1, 2025
23 of 43 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the v3-maintenance-8697 branch April 1, 2025 09:49
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 1, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emily-shen emily-shen emily-shen approved these changes

Assignees

No one assigned

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarmenPopoviciu @emily-shen @workers-devprod