Skip to content

Show latest instance by default #8973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Show latest instance by default #8973

merged 3 commits into from
May 22, 2025

Conversation

@Caio-Nogueira
Copy link
Contributor

@Caio-Nogueira Caio-Nogueira commented Apr 16, 2025 •
edited
Loading

Fixes WOR-290

For convenience reasons, we default to the latest instance on the wrangler instances describe <WORKFLOW_NAME> command. The id field becomes optional.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a patch change

@Caio-Nogueira Caio-Nogueira added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 16, 2025
@Caio-Nogueira Caio-Nogueira requested a review from a team as a code owner April 16, 2025 11:01
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6484b59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main enhancement/workflows-latest-instance might be a good starting point.

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-wrangler-8973
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-workers-bindings-extension-8973 -O ./cloudflare-workers-bindings-extension.0.0.0-vc8e72d560.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc8e72d560.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-create-cloudflare-8973 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-kv-asset-handler-8973

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-miniflare-8973

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-pages-shared-8973

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-unenv-preset-8973

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-vite-plugin-8973

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-vitest-pool-workers-8973

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-workers-editor-shared-8973

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-workers-shared-8973

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15185575450/npm-package-cloudflare-workflows-shared-8973

Note that these links will no longer work once the GitHub Actions artifact expires.

@Caio-Nogueira Caio-Nogueira mentioned this pull request Apr 16, 2025
Closed
emily-shen
emily-shen reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@emily-shen emily-shen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs need to be updated here: https://developers.cloudflare.com/workers/wrangler/commands/#instances-describe

emily-shen
emily-shen reviewed Apr 17, 2025
View reviewed changes
@Caio-Nogueira Caio-Nogueira force-pushed the enhancement/workflows-latest-instance branch from 339a29c to b144f6e Compare April 17, 2025 09:08
@Caio-Nogueira Caio-Nogueira mentioned this pull request Apr 17, 2025
Merged
1 task
@Caio-Nogueira Caio-Nogueira force-pushed the enhancement/workflows-latest-instance branch from b144f6e to 37293d3 Compare April 17, 2025 09:35
CarmenPopoviciu
CarmenPopoviciu reviewed Apr 22, 2025
View reviewed changes
@Caio-Nogueira Caio-Nogueira force-pushed the enhancement/workflows-latest-instance branch from 37293d3 to 21067b0 Compare April 22, 2025 14:57
CarmenPopoviciu
CarmenPopoviciu reviewed Apr 24, 2025
View reviewed changes
@LuisDuarte1
Copy link
Contributor

LuisDuarte1 commented Apr 24, 2025 •
edited
Loading

Why is this needed? there's already the "latest" flag as in: wrangler workflows instances describe <workflow_name> latest

I don't know if making the id optional is semantic or not.

@vicb
Copy link
Contributor

vicb commented May 5, 2025

@Caio-Nogueira @LuisDuarte1 could you agree on what's need to be done here?

@vicb vicb added the awaiting reporter response Needs clarification or followup from OP label May 5, 2025
@petebacondarwin petebacondarwin added the internal Requires support from the Cloudflare Platform label May 6, 2025
@Caio-Nogueira
Copy link
Contributor Author

Caio-Nogueira commented May 6, 2025

@Caio-Nogueira @LuisDuarte1 could you agree on what's need to be done here?

Maybe you can help here as well @bruxodasilva

@bruxodasilva
Copy link
Contributor

bruxodasilva commented May 6, 2025

Please, let's approve this PR. It simplifies the life of our customer and makes the CLI more convenient.

@Caio-Nogueira Caio-Nogueira force-pushed the enhancement/workflows-latest-instance branch 2 times, most recently from 1a9e81d to 6c19dc5 Compare May 22, 2025 09:52
@Caio-Nogueira Caio-Nogueira force-pushed the enhancement/workflows-latest-instance branch from 6c19dc5 to 4683d5c Compare May 22, 2025 10:34
@vicb vicb added the caretaking Priority for caretaking label May 22, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk May 22, 2025
vicb
vicb reviewed May 22, 2025
View reviewed changes
@vicb vicb enabled auto-merge May 22, 2025 11:37
@vicb vicb added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit cc7fae4 May 22, 2025
18 checks passed
@vicb vicb deleted the enhancement/workflows-latest-instance branch May 22, 2025 11:43
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk May 22, 2025
@workers-devprod workers-devprod mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu left review comments

@emily-shen emily-shen emily-shen left review comments

Assignees

No one assigned

Labels

awaiting reporter response Needs clarification or followup from OP caretaking Priority for caretaking e2e Run wrangler + vite-plugin e2e tests on a PR internal Requires support from the Cloudflare Platform

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Caio-Nogueira @LuisDuarte1 @vicb @bruxodasilva @CarmenPopoviciu @emily-shen @petebacondarwin