add remote bindings support to `getPlatformProxy` #9688

dario-piotrowicz · 2025-06-19T23:30:48Z

Fixes https://jira.cfdata.org/browse/DEVX-2028

add remote bindings support to getPlatformProxy

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): add experimental remoteBindings option to getPlatformProxy docs cloudflare-docs#23136
- [] Documentation not necessary because:
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: not a wrangler v3 feature

changeset-bot · 2025-06-19T23:30:52Z

🦋 Changeset detected

Latest commit: 86f2189

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-06-19T23:35:23Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9688

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9688

miniflare

npm i https://pkg.pr.new/miniflare@9688

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9688

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9688

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9688

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9688

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9688

wrangler

npm i https://pkg.pr.new/wrangler@9688

commit: 86f2189

packages/wrangler/src/api/integrations/platform/index.ts

penalosa · 2025-06-19T23:43:00Z

packages/wrangler/src/dev/miniflare.ts

-			remoteProxyConnectionString,
-			remoteBindingsEnabled
-		);
+		buildMiniflareBindingOptions(config, remoteProxyConnectionString);


This isn't quite right. "enabled" and "has a connection string" are subtly different—even without a connection string, "enabled" will affect things like Images local mode and the logged warnings

no.... I don't think I quite follow... 😕

well since this change is quite irrelevant to getPlatformProxy I am also happy to revert this aspect of the PR and revisit this later 🤔

put back explicit `remoteBindingsEnabled`

@ts-ignore

replace @ts-ignore to the more appropriate @ts-expect-error

replace variable `a`

make `preExistingRemoteProxySessionData` param optional

set the process.env cloudflare id and token so that getPlatformProxy can inherit them

add helpful comment

fixtures/get-platform-proxy-remote-bindings-node-test/index.test.js

.changeset/better-sheep-reply.md

packages/wrangler/src/api/integrations/platform/index.ts

refactor `getMiniflareOptionsFromConfig`

pass an args object to `getMiniflareOptionsFromConfig`

add example to changelog

penalosa

Some nits, but overall lgtm

fixtures/get-platform-proxy-remote-bindings-node-test/index.test.js

packages/wrangler/src/api/integrations/platform/index.ts

penalosa · 2025-06-20T15:05:52Z

packages/wrangler/src/api/integrations/platform/index.ts

+	const {
+		rawConfig,
+		targetEnvironment,
+		options,
+		remoteProxyConnectionString,
+		remoteBindingsEnabled,
+	} = args;


nit, but this destructing seems a bit messy to me.

I totally agree

I was simply passing the values as an object as requested, I am happy to either revert the change or proceed any way you see fit (like always passing args around?)

I prefer the current version FWIW

It's pretty much entirely a style choice, so I'll leave it up to your judgement @dario-piotrowicz, but fwiw I don't think it necessarily makes sense to change this function to accept an object of options. remoteBindingsEnabled is temporary while we're in the experimental phase, and IMO 4 parameters is a perfectly reasonable numbr of parameters to a function. Making it an options object adds this destructuring, which in my mind just means that there's an extra 7 lines of boilerplate obscuring what this function does. If we want to keep it as an options object, I would find either 1) using args.remoteProxyConnectionString etc... consistently throughout the function body or 2) destructuring in the function definition much clearer to read.

remove unnecessary `env` object

packages/wrangler/src/api/integrations/platform/index.ts

remove unnecessary intermediary variable

vicb · 2025-06-20T15:25:44Z

packages/wrangler/src/api/integrations/platform/index.ts

-		const maybeRemoteProxySessionWrap =
-			await maybeStartOrUpdateRemoteProxySession(rawConfig.configPath);
-		remoteProxySession = maybeRemoteProxySessionWrap?.session;
+		remoteProxySession = (


That look messy to me. IMO the former version looked better!

and by that I also mean that you do not have to implement all comments if they don't make sense to you - even my comments :)

Yeah, this wasn't quite what I was suggestion. I was thinking of (await maybeStartOrUpdateRemoteProxySession(config.configPath))?. session.

That said, this was mostly because the intermediate variable didn't add much clarity. What about:

({session: remoteProxySession } = await maybeStartOrUpdateRemoteProxySession(config.configPath)

…seba/containers_scope_debug * 'main' of ssh://github.com/cloudflare/workers-sdk: Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)

…seba/containers_scope * 'main' of ssh://github.com/cloudflare/workers-sdk: Add CLAUDE.md for Claude Code guidance (cloudflare#9563) Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)

dario-piotrowicz requested a review from a team as a code owner June 19, 2025 23:30

dario-piotrowicz added e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR labels Jun 19, 2025

workers-devprod added this to workers-sdk Jun 19, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Jun 19, 2025

add remote bindings support to getPlatformProxy

42c2d23

dario-piotrowicz force-pushed the dario/DEVX-2028/mixed-mode-get-platform-proxy branch from 478eb47 to 42c2d23 Compare June 19, 2025 23:33

penalosa reviewed Jun 19, 2025

View reviewed changes

dario-piotrowicz mentioned this pull request Jun 19, 2025

add experimental remoteBindings option to getPlatformProxy docs cloudflare/cloudflare-docs#23136

Merged

dario-piotrowicz added 4 commits June 20, 2025 01:02

fixup! add remote bindings support to getPlatformProxy

10e7f66

put back explicit `remoteBindingsEnabled`

fixup! add remote bindings support to getPlatformProxy

d3bcc90

replace @ts-ignore to the more appropriate @ts-expect-error

fixup! add remote bindings support to getPlatformProxy

d9f0a7f

replace variable `a`

fixup! add remote bindings support to getPlatformProxy

b44fad4

make `preExistingRemoteProxySessionData` param optional

dario-piotrowicz requested a review from penalosa June 20, 2025 00:13

dario-piotrowicz added 2 commits June 20, 2025 01:53

fixup! add remote bindings support to getPlatformProxy

0e1b23c

set the process.env cloudflare id and token so that getPlatformProxy can inherit them

fixup! add remote bindings support to getPlatformProxy

41ed675

add helpful comment

dario-piotrowicz mentioned this pull request Jun 20, 2025

[FEATURE] Remote Bindings While Using Next Dev opennextjs/opennextjs-cloudflare#457

Closed

2 tasks

vicb reviewed Jun 20, 2025

View reviewed changes

fixtures/get-platform-proxy-remote-bindings-node-test/index.test.js Show resolved Hide resolved

vicb reviewed Jun 20, 2025

View reviewed changes

.changeset/better-sheep-reply.md Show resolved Hide resolved

vicb reviewed Jun 20, 2025

View reviewed changes

packages/wrangler/src/api/integrations/platform/index.ts Outdated Show resolved Hide resolved

dario-piotrowicz added 3 commits June 20, 2025 10:20

fixup! add remote bindings support to getPlatformProxy

2a248ae

refactor `getMiniflareOptionsFromConfig`

fixup! add remote bindings support to getPlatformProxy

b67b22f

pass an args object to `getMiniflareOptionsFromConfig`

fixup! add remote bindings support to getPlatformProxy

3684fa7

add example to changelog

dario-piotrowicz requested a review from vicb June 20, 2025 09:51

penalosa approved these changes Jun 20, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 20, 2025

fixup! add remote bindings support to getPlatformProxy

90aed0a

remove unnecessary `env` object

vicb reviewed Jun 20, 2025

View reviewed changes

packages/wrangler/src/api/integrations/platform/index.ts Outdated Show resolved Hide resolved

dario-piotrowicz added 3 commits June 20, 2025 16:17

fixup! add remote bindings support to getPlatformProxy

e78b859

remove unnecessary intermediary variable

revert targetEnvironment variable renaming

5f1d352

remove extra env passing

869a6fd

vicb reviewed Jun 20, 2025

View reviewed changes

rename rawConfig to just config

86f2189

CarmenPopoviciu merged commit 086e29d into main Jun 20, 2025
27 checks passed

CarmenPopoviciu deleted the dario/DEVX-2028/mixed-mode-get-platform-proxy branch June 20, 2025 16:38

github-project-automation bot moved this from Approved to Done in workers-sdk Jun 20, 2025

workers-devprod mentioned this pull request Jun 20, 2025

Version Packages #9697

Merged

reinismu mentioned this pull request Jul 15, 2025

[Feature] Access remote bindings while building the app opennextjs/opennextjs-cloudflare#254

Closed

add remote bindings support to getPlatformProxy #9688

add remote bindings support to getPlatformProxy #9688

Uh oh!

Conversation

dario-piotrowicz commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

penalosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

add remote bindings support to `getPlatformProxy` #9688

add remote bindings support to `getPlatformProxy` #9688

dario-piotrowicz commented Jun 19, 2025 •

edited

Loading

changeset-bot bot commented Jun 19, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 19, 2025 •

edited

Loading