Skip to content

add remote bindings support to getPlatformProxy #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 20, 2025
Merged

add remote bindings support to getPlatformProxy #9688

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
42c2d23
add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 19, 2025
10e7f66
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
d3bcc90
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
d9f0a7f
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
b44fad4
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
0e1b23c
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
41ed675
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
2a248ae
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
b67b22f
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
3684fa7
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
90aed0a
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
e78b859
fixup! add remote bindings support to `getPlatformProxy`
dario-piotrowicz Jun 20, 2025
5f1d352
revert targetEnvironment variable renaming
dario-piotrowicz Jun 20, 2025
869a6fd
remove extra env passing
dario-piotrowicz Jun 20, 2025
86f2189
rename rawConfig to just config
dario-piotrowicz Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/wrangler/src/api/integrations/platform/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ export async function getPlatformProxy<

let remoteProxySession: RemoteProxySession | undefined = undefined;
if (experimentalRemoteBindings && rawConfig.configPath) {
const maybeRemoteProxySessionWrap =
await maybeStartOrUpdateRemoteProxySession(rawConfig.configPath);
remoteProxySession = maybeRemoteProxySessionWrap?.session;
remoteProxySession = (
Copy link
Contributor

@vicb vicb Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That look messy to me. IMO the former version looked better!

Copy link
Contributor

@vicb vicb Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and by that I also mean that you do not have to implement all comments if they don't make sense to you - even my comments :)

Copy link
Contributor

@penalosa penalosa Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this wasn't quite what I was suggestion. I was thinking of (await maybeStartOrUpdateRemoteProxySession(config.configPath))?. session.

That said, this was mostly because the intermediate variable didn't add much clarity. What about:

({session: remoteProxySession } = await maybeStartOrUpdateRemoteProxySession(config.configPath)

(await maybeStartOrUpdateRemoteProxySession(rawConfig.configPath)) ?? {}
).session;
}

const miniflareOptions = await getMiniflareOptionsFromConfig({
Expand Down
Loading