Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jun 25, 2025

The Version Packages PR is currently failing on vitest re-run tests on windows.

I tested it here and it does look like the issue comes from the workerd bump from #9744, so this PR is for reverting such bump, this should enable us to land the version packages PR tomorrow as planned. Afterwords we'll properly investigate and potentially coordinate with the runtime team to solve the windows workerd issue.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: workerd bump revert
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: workerd bump revert
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: the bump is not in v3

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner June 25, 2025 19:33
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: 27d57b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz dario-piotrowicz marked this pull request as draft June 25, 2025 19:33
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 25, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 25, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9750

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9750

miniflare

npm i https://pkg.pr.new/miniflare@9750

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9750

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9750

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9750

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9750

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9750

wrangler

npm i https://pkg.pr.new/wrangler@9750

commit: 27d57b0

@dario-piotrowicz dario-piotrowicz force-pushed the dario/fix-vitest-ci-windows-test branch from 15686b3 to 27d57b0 Compare June 25, 2025 19:54
@dario-piotrowicz dario-piotrowicz changed the title Debugging vitest ci windows failures Revert "Bump the workerd-and-workers-types group with 2 updates (#9744)" Jun 25, 2025
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 25, 2025 20:45
@dario-piotrowicz dario-piotrowicz added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 25, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 26, 2025
@dario-piotrowicz dario-piotrowicz merged commit 2355499 into main Jun 26, 2025
47 of 53 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/fix-vitest-ci-windows-test branch June 26, 2025 07:59
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants