Stop using *pointer in analyticsd daemon to avoid random panics

aemengo · aemengo · commit bd5b55591a50 · 2018-09-11T17:53:08.000-04:00
http://ci.pcfdev.io/teams/main/pipelines/cfdev/jobs/build/builds/501#L5b96c882:14:59
diff --git a/analyticsd/daemon/daemon.go b/analyticsd/daemon/daemon.go
@@ -28,7 +28,7 @@ type Daemon struct {
 	ticker          *time.Ticker
 	pollingInterval time.Duration
 	logger          *log.Logger
-	lastTime        *time.Time
+	lastTime        time.Time
 	doneChan        chan bool
 }
 
@@ -257,7 +257,7 @@ func eventTypesFilter() string {
 
 func (d *Daemon) saveLatestTime(t time.Time) {
 	t = t.UTC()
-	if d.lastTime == nil || t.After(*d.lastTime) {
-		d.lastTime = &t
+	if t.After(d.lastTime) {
+		d.lastTime = t
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ type Daemon struct {`
`28`	`28`	`ticker *time.Ticker`
`29`	`29`	`pollingInterval time.Duration`
`30`	`30`	`logger *log.Logger`
`31`		`- lastTime *time.Time`
	`31`	`+ lastTime time.Time`
`32`	`32`	`doneChan chan bool`
`33`	`33`	`}`
`34`	`34`
`@@ -257,7 +257,7 @@ func eventTypesFilter() string {`
`257`	`257`
`258`	`258`	`func (d *Daemon) saveLatestTime(t time.Time) {`
`259`	`259`	`t = t.UTC()`
`260`		`- if d.lastTime == nil \|\| t.After(*d.lastTime) {`
`261`		`- d.lastTime = &t`
	`260`	`+ if t.After(d.lastTime) {`
	`261`	`+ d.lastTime = t`
`262`	`262`	`}`
`263`	`263`	`}`