Skip to content

Commit 12f29f5

Browse files
committed
fix: Rename from get to list revisions
1 parent 93b9e72 commit 12f29f5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cloudfoundry_client/v3/apps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ def get_routes(self, application_guid: str) -> JsonObject:
2828
def get_manifest(self, application_guid: str) -> str:
2929
return self.client.get(url="%s%s/%s/manifest" % (self.target_endpoint, self.entity_uri, application_guid)).text
3030

31-
def get_revisions(self, application_guid: str, **kwargs) -> Pagination[Entity]:
31+
def list_revisions(self, application_guid: str, **kwargs) -> Pagination[Entity]:
3232
uri: str = "%s/%s/revisions" % (self.entity_uri, application_guid)
3333
return super(AppManager, self)._list(requested_path=uri, **kwargs)
3434

35-
def get_deployed_revisions(self, application_guid: str, **kwargs) -> Pagination[Entity]:
35+
def list_deployed_revisions(self, application_guid: str, **kwargs) -> Pagination[Entity]:
3636
uri: str = "%s/%s/revisions/deployed" % (self.entity_uri, application_guid)
3737
return super(AppManager, self)._list(requested_path=uri, **kwargs)

tests/v3/test_apps.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,12 @@ def test_get_manifest(self):
161161
self.assertEqual(application_route.get("route"), "my-app.example.com")
162162
self.assertEqual(application_route.get("protocol"), "http1")
163163

164-
def test_get_revisions(self):
164+
def test_list_revisions(self):
165165
self.client.get.return_value = self.mock_response(
166166
"/v3/apps/app_guid/revisions", HTTPStatus.OK, {"Content-Type": "application/json"}, "v3", "apps",
167167
"GET_{id}_revisions_response.json"
168168
)
169-
revisions_response: Pagination[Entity] = self.client.v3.apps.get_revisions("app_guid")
169+
revisions_response: Pagination[Entity] = self.client.v3.apps.list_revisions("app_guid")
170170
revisions: list[dict] = [revision for revision in revisions_response]
171171
self.assertIsInstance(revisions, list)
172172
self.assertEqual(len(revisions), 1)
@@ -176,12 +176,12 @@ def test_get_revisions(self):
176176
self.assertEqual(revision.get("description"), "Initial revision.")
177177
self.assertEqual(revision.get("deployable"), True)
178178

179-
def test_get_deployed_revisions(self):
179+
def test_list_deployed_revisions(self):
180180
self.client.get.return_value = self.mock_response(
181181
"/v3/apps/app_guid/revisions/deployed", HTTPStatus.OK, {"Content-Type": "application/json"}, "v3", "apps",
182182
"GET_{id}_deployed_revisions_response.json"
183183
)
184-
revisions_response: Pagination[Entity] = self.client.v3.apps.get_deployed_revisions("app_guid")
184+
revisions_response: Pagination[Entity] = self.client.v3.apps.list_deployed_revisions("app_guid")
185185
revisions: list[dict] = [revision for revision in revisions_response]
186186
self.assertIsInstance(revisions, list)
187187
self.assertEqual(len(revisions), 1)

0 commit comments

Comments
 (0)