invet condition

Author: Scott Schulthess

git.go

@@ -89,7 +89,14 @@ func (g *GitClient) Init(branch string) error {
 	if err := g.command("git", "config", "--global", "user.email", "concourse@local").Run(); err != nil {
 		return fmt.Errorf("failed to configure git email: %s", err)
 	}
-	if g.UseGithubApp {
+	if err := g.command("git", "config", "--global", "url.https://.insteadOf", "git://").Run(); err != nil {
+		return fmt.Errorf("failed to configure github url: %s", err)
+	}
+	if !g.UseGithubApp {
+		if err := g.command("git", "config", "url.https://[email protected]/.insteadOf", "[email protected]:").Run(); err != nil {
+			return fmt.Errorf("failed to configure github url: %s", err)
+		}
+	} else {
 		filePath := "/tmp/git-resource-private-key"
 		err := ioutil.WriteFile(filePath, []byte(g.PrivateKey), 0600)
 		if err != nil {
@@ -101,16 +108,6 @@ func (g *GitClient) Init(branch string) error {
 		if err := g.command("git", "config", "credential.https://github.com.helper", helperStr).Run(); err != nil {
 			return fmt.Errorf("failed to configure github url: %s", err)
 		}
-	} else {
-		if err := g.command("git", "config", "url.https://[email protected]/.insteadOf", "[email protected]:").Run(); err != nil {
-			return fmt.Errorf("failed to configure github url: %s", err)
-		}
-	}
-	if err := g.command("git", "config", "--global", "url.https://[email protected]/.insteadOf", "[email protected]:").Run(); err != nil {
-		return fmt.Errorf("failed to configure github url: %s", err)
-	}
-	if err := g.command("git", "config", "--global", "url.https://.insteadOf", "git://").Run(); err != nil {
-		return fmt.Errorf("failed to configure github url: %s", err)
 	}
 	return nil
 }