Skip to content

Commit 9b3fd3e

Browse files
thquadrichard-cox
authored andcommitted
Add comment and clean up code (#4876)
Signed-off-by: Thomas Quandt <[email protected]>
1 parent 0f13b56 commit 9b3fd3e

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,8 @@ export class EndpointListHelper {
172172
label: 'Unregister',
173173
description: 'Remove the endpoint',
174174
createVisible: (row$: Observable<EndpointModel>) => {
175+
// I think if we end up using these often there should be specific create,
176+
// edit, delete style permissions in the stratos permissions checker
175177
return combineLatest([
176178
this.sessionService.userEndpointsNotDisabled(),
177179
this.currentUserPermissionsService.can(StratosCurrentUserPermissions.EDIT_ADMIN_ENDPOINT),

src/jetstream/cnsi_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -570,12 +570,6 @@ func TestRegisterWithUserEndpointsEnabled(t *testing.T) {
570570

571571
})
572572
})
573-
574-
Convey("with UserEndpointsEnabled=disabled", func() {
575-
Convey("register existing user endpoint", func() {
576-
// todo user endpoints should automatically overwritten?
577-
})
578-
})
579573
})
580574
}
581575

0 commit comments

Comments
 (0)