route service binding resource: migrate to ccv3

Author: Cocossoul

cloudfoundry/resource_cf_route_service_binding.go

@@ -2,7 +2,14 @@ package cloudfoundry
 
 import (
 	"context"
+	"fmt"
+	"log"
+	"strings"
+
+	"github.com/cloudfoundry/go-cfclient/v3/client"
+	"github.com/cloudfoundry/go-cfclient/v3/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 	"github.com/terraform-providers/terraform-provider-cloudfoundry/cloudfoundry/managers"
 
 	"encoding/json"
@@ -38,18 +45,16 @@ func resourceRouteServiceBinding() *schema.Resource {
 				ForceNew: true,
 			},
 		},
+		SchemaVersion: 1,
+		MigrateState:  resourceRouteServiceBindingMigrateState,
 	}
 }
 
-func resourceRouteServiceBindingImport(ctx context.Context, d *schema.ResourceData, meta interface{}) (res []*schema.ResourceData, err error) {
-	id := d.Id()
-	if _, _, err = parseID(id); err != nil {
-		return
-	}
+func resourceRouteServiceBindingImport(ctx context.Context, d *schema.ResourceData, meta any) (res []*schema.ResourceData, err error) {
 	return ImportReadContext(resourceRouteServiceBindingRead)(ctx, d, meta)
 }
 
-func resourceRouteServiceBindingCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func resourceRouteServiceBindingCreate(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
 	session := meta.(*managers.Session)
 
 	var data map[string]interface{}
@@ -63,48 +68,116 @@ func resourceRouteServiceBindingCreate(ctx context.Context, d *schema.ResourceDa
 			return diag.FromErr(err)
 		}
 	}
-	_, err := session.ClientV2.CreateServiceBindingRoute(serviceID, routeID, data)
+
+	jobGUID, _, err := session.ClientGo.ServiceRouteBindings.Create(context.Background(), &resource.ServiceRouteBindingCreate{
+		Relationships: resource.ServiceRouteBindingRelationships{
+			// ServiceInstance ToOneRelationship `json:"service_instance"`
+			// // The route that the service instance is bound to
+			// Route ToOneRelationship `json:"route"`
+			ServiceInstance: resource.ToOneRelationship{
+				Data: &resource.Relationship{
+					GUID: serviceID,
+				},
+			},
+			Route: resource.ToOneRelationship{
+				Data: &resource.Relationship{
+					GUID: routeID,
+				},
+			},
+		},
+	})
+
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	if jobGUID != "" {
+		err = session.ClientGo.Jobs.PollComplete(context.Background(), jobGUID, nil)
+	}
 	if err != nil {
 		return diag.FromErr(err)
 	}
 
-	d.SetId(computeID(serviceID, routeID))
+	options := client.NewServiceRouteBindingListOptions()
+	options.ServiceInstanceGUIDs = client.Filter{Values: []string{serviceID}}
+	options.RouteGUIDs = client.Filter{Values: []string{routeID}}
+
+	routeBinding, err := session.ClientGo.ServiceRouteBindings.Single(context.Background(), options)
+
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	d.SetId(routeBinding.GUID)
 	return nil
 }
 
-func resourceRouteServiceBindingRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func resourceRouteServiceBindingRead(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
 	session := meta.(*managers.Session)
 
-	serviceID, routeID, err := parseID(d.Id())
+	routeServiceBinding, err := session.ClientGo.ServiceRouteBindings.Get(context.Background(), d.Id())
+
 	if err != nil {
-		return diag.FromErr(err)
+		if strings.Contains(err.Error(), "CF-ResourceNotFound") {
+			d.SetId("")
+			return nil
+		}
+		return diag.Errorf("Error when reading routeServiceBinding with id '%s': %s", d.Id(), err)
 	}
-	routes, _, err := session.ClientV2.GetServiceBindingRoutes(serviceID)
+
+	d.Set("service_instance", routeServiceBinding.Relationships.ServiceInstance.Data.GUID)
+	d.Set("route", routeServiceBinding.Relationships.Route.Data.GUID)
+
+	return nil
+}
+
+func resourceRouteServiceBindingDelete(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
+	session := meta.(*managers.Session)
+
+	jobGUID, err := session.ClientGo.ServiceRouteBindings.Delete(context.Background(), d.Id())
+
 	if err != nil {
 		return diag.FromErr(err)
 	}
-	found := false
-	for _, route := range routes {
-		if route.GUID == routeID {
-			found = true
-			break
-		}
-	}
-	if !found {
-		d.SetId("")
-		return diag.Errorf("Route '%s' not found in service instance '%s'", routeID, serviceID)
+	if jobGUID != "" {
+		err = session.ClientGo.Jobs.PollComplete(context.Background(), jobGUID, nil)
 	}
+	return diag.FromErr(err)
+}
 
-	d.Set("service_instance", serviceID)
-	d.Set("route", routeID)
-	return nil
+func resourceRouteServiceBindingMigrateState(v int, inst *terraform.InstanceState, meta any) (*terraform.InstanceState, error) {
+	switch v {
+	case 0:
+		log.Println("[INFO] Found Route Service Binding State v0; migrating to v1: change ID from routeID:serviceID to routeServiceBindingID.")
+		return migrateRouteServiceBindingStateV0toV1ChangeID(inst, meta)
+	default:
+		return inst, fmt.Errorf("Unexpected schema version: %d", v)
+	}
 }
 
-func resourceRouteServiceBindingDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func migrateRouteServiceBindingStateV0toV1ChangeID(inst *terraform.InstanceState, meta any) (*terraform.InstanceState, error) {
 	session := meta.(*managers.Session)
 
-	serviceID := d.Get("service_instance").(string)
-	routeID := d.Get("route").(string)
-	_, err := session.ClientV2.DeleteServiceBindingRoute(serviceID, routeID)
-	return diag.FromErr(err)
+	if inst.Empty() {
+		log.Println("[DEBUG] Empty RouteServiceBinding; nothing to migrate.")
+		return inst, nil
+	}
+
+	log.Printf("[DEBUG] Attributes before migration: %#v", inst.Attributes)
+	options := client.NewServiceRouteBindingListOptions()
+	options.ServiceInstanceGUIDs = client.Filter{Values: []string{inst.Attributes["service_instance"]}}
+	options.RouteGUIDs = client.Filter{Values: []string{inst.Attributes["route"]}}
+
+	routeBinding, err := session.ClientGo.ServiceRouteBindings.Single(context.Background(), options)
+
+	if err != nil {
+		log.Println("[DEBUG] Failed to migrate RouteServiceBinding id: did not find the route service binding.")
+		return inst, err
+	}
+
+	inst.Attributes["id"] = routeBinding.GUID
+
+	log.Printf("[DEBUG] Attributes after migration: %#v", inst.Attributes)
+
+	return inst, nil
 }