Fixes;

Author: joergdw

api/brokerserver/broker_handler_test.go

@@ -1186,7 +1186,10 @@ var _ = Describe("BrokerHandler", func() {
 				It("fails with 400", func() {
 					Expect(resp.Code).To(Equal(http.StatusBadRequest))
 					Expect(resp.Body.String()).To(MatchJSON(
-						`{"error": "InvalidPolicy", "description": "invalid policy provided: [{\"context\":\"(root)\",\"description\":\"Must validate one and only one schema (oneOf)\"},{\"context\":\"(root).credential-type\",\"description\":\"credential-type must be one of the following: \\\"x509\\\", \\\"binding-secret\\\"\"}]"}`,
+						`{
+						  "error": "InvalidPolicy",
+						  "description": "invalid policy provided: [{\"context\":\"(root)\",\"description\":\"Must validate one and only one schema (oneOf)\"},{\"context\":\"(root)\",\"description\":\"Must validate one and only one schema (oneOf)\"},{\"context\":\"(root)\",\"description\":\"schema-version is required\"},{\"context\":\"(root).credential-type\",\"description\":\"credential-type must be one of the following: \\\"x509\\\", \\\"binding-secret\\\"\"}]"
+						}`,
 					))
 				})
 

api/policyvalidator/json-schema/Readme.md

@@ -0,0 +1,7 @@
+# Read-me #
+
+The currently used golang-library for json-schema, namely “[gojsonschema](<https://github.com/xeipuuv/gojsonschema>)” not seems to be capable to resolve references to other files correctly across different directories. Perhaps not limited to but especially when referencing up the file-system-hierarchy (parent-directories). In theory, symbolic links can be used to circumvent the issue … if there would not be another weakness in <https://github.com/cloudfoundry/bosh-compile-action> which we currently use in the workflow [bosh-release-checks.yaml](<../../../../.github/workflows/bosh-release-checks.yaml>) for making a compiled release: It can not handle symbolic links. Therefore it gets hard-linked here (which can not be tracked by git but it can somehow handle it!).
+
+After phasing out the bosh-technology of “Application Autoscaler”, these hardlinks can be removed.
+
+⚠️ This means the consinstence needs to be ensured manually. There is no CI/CD-check because Bosh is already in its phase-out for “Application Autoscaler”.

api/policyvalidator/json-schema/meta.schema.json

@@ -4,7 +4,7 @@
   "description": "Unification of different schemas for scaling-policies for Autoscaler",
 
   "oneOf": [
-    {"$ref": "./v0_1/meta.schema.json"},
+    {"$ref": "./v0.1/meta.schema.json"},
     {"$ref": "./legacy.schema.json"}
   ]
 }

api/policyvalidator/policy_validator_test.go

@@ -48,7 +48,7 @@ var _ = Describe("PolicyValidator", func() {
 		upperDiskThreshold = 2 * 1024
 
 		policyValidator = NewPolicyValidator(
-			"./meta.schema.json",
+			"./json-schema/meta.schema.json",
 			lowerCPUThreshold,
 			upperCPUThreshold,
 			lowerCPUUtilThreshold,

integration/components_test.go

@@ -232,7 +232,7 @@ func DefaultGolangAPITestConfig() apiConfig.Config {
 		},
 		CatalogPath:          "../servicebroker/config/catalog.json",
 		CatalogSchemaPath:    "../api/schemas/catalog.schema.json",
-		PolicySchemaPath:     "../api/policyvalidator/json-schema/meta.schema.json",
+		PolicySchemaPath:     "../api/policyvalidator/meta.schema.json",
 		InfoFilePath:         "../api/exampleconfig/catalog-example.json",
 		DashboardRedirectURI: "",
 		CF: cf.Config{