Make legacy-parser work initially (in a single test-case);

Author: joergdw

api/broker/binding_request_parser/binding-request-parser_test.go

@@ -1,6 +1,8 @@
 package binding_request_parser_test
 
 import (
+	"path/filepath"
+
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 
@@ -49,7 +51,6 @@ var _ = Describe("BindingRequestParsers", func() {
 	const validLegacyBindingRequestRaw string = `
 		{
 		 "configuration": {
-			 "app_guid": "8d0cee08-23ad-4813-a779-ad8118ea0b91",
 			 "custom_metrics": {
 			   "metric_submission_strategy": {
 				   "allow_from": "bound_app"
@@ -104,11 +105,14 @@ var _ = Describe("BindingRequestParsers", func() {
 
 	Describe("LegacyBindingRequestParser", func() {
 		var (
-			legacyParser lp.LegacyBindingRequestParser
-			err          error
+			legacyParser      lp.LegacyBindingRequestParser
+			schemaFilePathAbs string
+			err               error
 		)
 		var _ = BeforeEach(func() {
-			legacyParser, err = lp.New()
+			schemaFilePathAbs, err = filepath.Abs("./legacy_parser/schema.json")
+			Expect(err).NotTo(HaveOccurred())
+			legacyParser, err = lp.New("file://" + schemaFilePathAbs)
 			Expect(err).NotTo(HaveOccurred())
 		})
 

api/broker/binding_request_parser/legacy_parser/parser.go

@@ -16,8 +16,14 @@ type LegacyBindingRequestParser struct {
 
 var _ binding_request_parser.Parser = LegacyBindingRequestParser{}
 
-func New() (LegacyBindingRequestParser, error) {
-	const schemaFilePath string = "file://./schema.json"
+// New creates a new LegacyBindingRequestParser with the JSON schema loaded from the specified file
+// path.
+//
+// The schemaFilePath parameter should be a valid and absolute file URI (e.g.,
+// "file:///path/to/schema.json").
+//
+// Returns an error if the schema file cannot be loaded or parsed.
+func New(schemaFilePath string) (LegacyBindingRequestParser, error) {
 	schemaLoader := gojsonschema.NewReferenceLoader(schemaFilePath)
 	schema, err := gojsonschema.NewSchema(schemaLoader)
 	if err != nil {
@@ -97,8 +103,7 @@ This must not happen because of prior schema-validation. This is a programming-e
 		strat, err := models.ParseCustomMetricsStrategy(
 			bindingReqParams.BindingConfig.CustomMetrics.MetricSubmissionStrategy.AllowFrom)
 
-		if err == nil {
-
+		if err != nil {
 			return models.AppScalingConfig{}, &models.InvalidArgumentError{
 				Param: "err",
 				Value: err,