resolve deprecation warning in aws_eip resource

sbogar-shs · jpalermo · commit 04c2c6b4d304 · 2025-03-27T08:47:25.000-07:00
resolve concourse-lb issue with aws_lb subnets property
diff --git a/terraform/aws/templates/base.tf b/terraform/aws/templates/base.tf
@@ -60,7 +60,7 @@ variable "vpc_cidr" {
 
 resource "aws_eip" "jumpbox_eip" {
   depends_on = [aws_internet_gateway.ig]
-  vpc        = true
+  domain     = "vpc"
 }
 
 resource "tls_private_key" "bosh_vms" {
@@ -138,7 +138,7 @@ resource "aws_nat_gateway" "nat" {
 }
 
 resource "aws_eip" "nat_eip" {
-  vpc = true
+  domain = "vpc"
 
   tags = {
     Name  = "${var.env_id}-nat"
diff --git a/terraform/aws/templates/concourse_lb.tf b/terraform/aws/templates/concourse_lb.tf
@@ -55,7 +55,7 @@ resource "aws_security_group_rule" "concourse_lb_internal_egress" {
 resource "aws_lb" "concourse_lb" {
   name               = "${var.short_env_id}-concourse-lb"
   load_balancer_type = "network"
-  subnets            = ["${aws_subnet.lb_subnets.*.id}"]
+  subnets            = flatten(["${aws_subnet.lb_subnets.*.id}"])
 
   tags = {
     Name = "${var.env_id}"

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ variable "vpc_cidr" {`
`60`	`60`
`61`	`61`	`resource "aws_eip" "jumpbox_eip" {`
`62`	`62`	`depends_on = [aws_internet_gateway.ig]`
`63`		`- vpc = true`
	`63`	`+ domain = "vpc"`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`resource "tls_private_key" "bosh_vms" {`
`@@ -138,7 +138,7 @@ resource "aws_nat_gateway" "nat" {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`resource "aws_eip" "nat_eip" {`
`141`		`- vpc = true`
	`141`	`+ domain = "vpc"`
`142`	`142`
`143`	`143`	`tags = {`
`144`	`144`	`Name = "${var.env_id}-nat"`