test: ops generator test with correct input

Author: peanball

cloudconfig/aws/ops_generator.go

@@ -103,15 +103,14 @@ func (o OpsGenerator) GenerateVars(state storage.State) (string, error) {
 	}
 	dualstackOutput, ok := terraformOutputs.Map["dualstack"]
 	if !ok {
-		return "", fmt.Errorf("dualstack output not present")
+		return "", fmt.Errorf("missing dualstack terraform output")
 	}
-	var dualstack bool
-	if dualstackOutput.(bool) {
+	dualstack := dualstackOutput.(bool)
+	if dualstack {
 		requiredOutputs = append(requiredOutputs,
 			"internal_cidr_ipv6",
 			"internal_az_subnet_ipv6_cidr_mapping",
 		)
-		dualstack = true
 	}
 
 	switch state.LB.Type {

cloudconfig/aws/ops_generator_test.go

@@ -47,7 +47,7 @@ var _ = Describe("OpsGenerator", func() {
 			"cf_tcp_lb_internal_security_group":    "some-cf-tcp-lb-internal-security-group",
 			"concourse_lb_target_groups":           []string{"some-concourse-lb-target-group", "some-other-concourse-lb-target-group"},
 			"concourse_lb_internal_security_group": "some-concourse-lb-internal-security-group",
-			"dualstack":                            "false",
+			"dualstack":                            false,
 			"internal_az_subnet_id_mapping": map[string]interface{}{
 				"us-east-1c": "some-internal-subnet-ids-3",
 				"us-east-1a": "some-internal-subnet-ids-1",
@@ -137,6 +137,7 @@ cf_tcp_lb_internal_security_group: some-cf-tcp-lb-internal-security-group
 cf_iso_router_lb_name: some-cf-iso-seg-router-lb-name
 concourse_lb_target_groups: [some-concourse-lb-target-group, some-other-concourse-lb-target-group]
 concourse_lb_internal_security_group: some-concourse-lb-internal-security-group
+dualstack: false
 internal_az_subnet_cidr_mapping:
   us-east-1a: 10.0.16.0/20
   us-east-1b: 10.0.32.0/20