Merge pull request #443 from s4heid/ubuntu-jammy-sriov

Ignore SR-IOV VF interfaces for Azure stemcells

Author: aramprice

bosh-stemcell/spec/stemcells/azure_spec.rb

@@ -42,4 +42,41 @@
       its(:content) { should include('"PartitionerType": "parted"') }
     end
   end
+
+  context 'installed by system_azure_network', {
+    exclude_on_alicloud: true,
+    exclude_on_aws: true,
+    exclude_on_google: true,
+    exclude_on_vcloud: true,
+    exclude_on_vsphere: true,
+    exclude_on_warden: true,
+    exclude_on_openstack: true,
+    exclude_on_softlayer: true,
+  } do
+    describe 'SR-IOV VF udev rules' do
+      subject { file('/etc/udev/rules.d/10-azure-sriov-unmanaged.rules') }
+
+      it { should be_mode(644) }
+      it { should be_owned_by('root') }
+
+      its(:content) { should match /SUBSYSTEM=="net"/ }
+      its(:content) { should match /ATTR\{flags\}=="0\?\?\[89ABCDEF\]\*"/ }
+      its(:content) { should match /ENV\{AZURE_UNMANAGED_SRIOV\}="1"/ }
+      its(:content) { should match /ENV\{ID_NET_MANAGED_BY\}="unmanaged"/ }
+      its(:content) { should match /ENV\{NM_UNMANAGED\}="1"/ }
+      its(:content) { should match /ATTR\{ifalias\}="sriov-vf"/ }
+    end
+
+    describe 'systemd network configuration for unmanaged SR-IOV devices' do
+      subject { file('/etc/systemd/network/01-azure-sriov-unmanaged.network') }
+
+      it { should be_mode(644) }
+      it { should be_owned_by('root') }
+
+      its(:content) { should match /\[Match\]/ }
+      its(:content) { should match /Property=AZURE_UNMANAGED_SRIOV=1/ }
+      its(:content) { should match /\[Link\]/ }
+      its(:content) { should match /Unmanaged=yes/ }
+    end
+  end
 end

stemcell_builder/stages/system_azure_network/apply.sh

@@ -20,3 +20,11 @@ EOS
 # The port 65330 is unusable on Azure
 cp $dir/assets/90-azure-sysctl.conf $chroot/etc/sysctl.d
 chmod 0644 $chroot/etc/sysctl.d/90-azure-sysctl.conf
+
+# Install SR-IOV VF udev rule to mark network interfaces as unmanaged and set ifalias
+cp $dir/assets/10-azure-sriov-unmanaged.rules $chroot/etc/udev/rules.d
+chmod 0644 $chroot/etc/udev/rules.d/10-azure-sriov-unmanaged.rules
+
+# Apply the systemd.network configuration, to ignore unmanaged devices
+cp $dir/assets/01-azure-sriov-unmanaged.network $chroot/etc/systemd/network
+chmod 0644 $chroot/etc/systemd/network/01-azure-sriov-unmanaged.network

stemcell_builder/stages/system_azure_network/assets/01-azure-sriov-unmanaged.network

@@ -0,0 +1,11 @@
+# Azure VMs with accelerated networking may have MANA, mlx4, or mlx5 SR-IOV
+# devices which are transparently bonded to a synthetic hv_netvsc device.
+#
+# 10-azure-unmanaged-sriov.rules will mark these devices with
+# AZURE_UNMANAGED_SRIOV=1, allowing this configuration to set them as unmanaged.
+
+[Match]
+Property=AZURE_UNMANAGED_SRIOV=1
+
+[Link]
+Unmanaged=yes

stemcell_builder/stages/system_azure_network/assets/10-azure-sriov-unmanaged.rules

@@ -0,0 +1,19 @@
+# Azure VMs with accelerated networking may have MANA, mlx4, or mlx5 SR-IOV devices
+# which are transparently bonded to a synthetic hv_netvsc device.
+#
+# Mark devices with the IFF_SLAVE bit set as unmanaged devices:
+#   AZURE_UNMANAGED_SRIOV=1:     Custom tag to mark the interface as unmanaged in systemd-networkd (01-azure-sriov-unmanaged.network).
+#   ID_NET_MANAGED_BY=unmanaged: Standard tag for systemd-networkd (v255+).
+#   NM_UNMANAGED=1:              Tells NetworkManager to ignore the interface.
+#
+# Additionally, set an ifalias to allow the bosh-agent to ignore the device, as both
+# interfaces, the synthetic and the VF interface, share the same MAC address and only
+# the synthetic interface should be used by the application.
+
+SUBSYSTEM=="net", ACTION!="remove", KERNEL!="lo", \
+    DRIVERS=="mana|mlx4_core|mlx5_core", \
+    ATTR{flags}=="0x?[89ABCDEF]*", \
+    ENV{AZURE_UNMANAGED_SRIOV}="1", \
+    ENV{ID_NET_MANAGED_BY}="unmanaged", \
+    ENV{NM_UNMANAGED}="1", \
+    ATTR{ifalias}="sriov-vf"