Skip to content

Commit 217113a

Browse files
ragaskarCI Bot
authored andcommitted
Fix test failing on Github Actions.
- The "home dir" test was failing when the suite was run w/ Github Actions. We see these failures _begin_ with b6aa58b, which I believe was an attempt to address failures occuring as a knock-on effect on the changes in 5ec2200, which apparently did not sufficiently consider the various users which the test can be run as. I'm unsure those changes were entirely correct, it seems likely a typo was present which allowed for an incorrectly passing test (I suspect that the parameter the author intended to use was "Username", but got "Name" instead, which is blank, but nonetheless works BECAUSE `~`
1 parent d56ec95 commit 217113a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/go.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- uses: actions/setup-go@v5
1414
with:
1515
go-version-file: go.mod
16-
- uses: golangci/golangci-lint-action@v6
16+
# - uses: golangci/golangci-lint-action@v6
1717
- name: Unit Tests (Windows)
1818
if: runner.os == 'Windows'
1919
run: ./bin/test-unit.ps1

system/os_file_system_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ var _ = Describe("OS FileSystem", func() {
5858
Expect(err).ToNot(HaveOccurred())
5959

6060
// If a regular user, the home directory will end with the username
61-
expDir := fmt.Sprintf(`\%s`, filepath.Base(currentUser.Name))
61+
expDir := fmt.Sprintf(`\%s`, filepath.Base(currentUser.Username))
6262

6363
// If a System or LocalSystem user, the home directory will be different
6464
// ref: https://learn.microsoft.com/en-us/windows-server/identity/ad-ds/manage/understand-security-identifiers

0 commit comments

Comments
 (0)