feat: Update the GolangCi-lint version

Author: ZPascal

.github/workflows/go.yml

@@ -13,7 +13,7 @@ jobs:
     - uses: actions/setup-go@v5
       with:
         go-version-file: go.mod
-    - uses: golangci/golangci-lint-action@v6
+    - uses: golangci/golangci-lint-action@v9
     - name: Unit Tests (Windows)
       if: runner.os == 'Windows'
       run: ./bin/test-unit.ps1

.golangci.yml

@@ -1,7 +1,21 @@
 # https://golangci-lint.run/usage/configuration/
-run:
-  timeout: 5m # 1m default times out on github-action runners
-
-output:
-  # Sort results by: filepath, line and column.
-  sort-results: true
+version: "2"
+linters:
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

crypto/multiple_digest.go

@@ -104,7 +104,7 @@ func (m MultipleDigest) VerifyFilePath(filePath string, fs boshsys.FileSystem) e
 
 func (m MultipleDigest) validate() error {
 	if len(m.digests) == 0 {
-		return errors.New("Expected to find at least one digest")
+		return errors.New("Expected to find at least one digest") //nolint:staticcheck
 	}
 
 	algosUsed := map[string]struct{}{}
@@ -192,7 +192,7 @@ func (m MultipleDigest) parseMultipleDigestString(multipleDigest string) (Multip
 	}
 
 	if len(digests) == 0 {
-		return MultipleDigest{}, errors.New("No digest algorithm found. Supported algorithms: sha1, sha256, sha512")
+		return MultipleDigest{}, errors.New("No digest algorithm found. Supported algorithms: sha1, sha256, sha512") //nolint:staticcheck
 	}
 
 	return MultipleDigest{digests: digests}, nil
@@ -213,7 +213,7 @@ func (MultipleDigest) parseDigestString(digest string) (Digest, error) {
 
 	for _, piece := range pieces {
 		if !isStringAlphanumeric(piece) {
-			return nil, errors.New("Unable to parse digest string. Digest and algorithm key can only contain alpha-numeric characters.")
+			return nil, errors.New("Unable to parse digest string. Digest and algorithm key can only contain alpha-numeric characters.") //nolint:staticcheck
 		}
 	}
 

errors/multi_error.go

@@ -13,7 +13,7 @@ func NewMultiError(errors ...error) error {
 }
 
 func (e MultiError) Error() string {
-	errors := make([]string, len(e.Errors), len(e.Errors)) //nolint:gosimple
+	errors := make([]string, len(e.Errors), len(e.Errors)) //nolint:staticcheck
 	for i, err := range e.Errors {
 		errors[i] = err.Error()
 	}

fileutil/tarball_compressor.go

@@ -53,7 +53,7 @@ func (c tarballCompressor) CompressSpecificFilesInDir(dir string, files []string
 		args = append([]string{"--no-mac-metadata"}, args...)
 	}
 
-	for _, file := range files { //nolint:gosimple
+	for _, file := range files { //nolint:staticcheck
 		args = append(args, file)
 	}
 

httpclient/http_client.go

@@ -171,7 +171,7 @@ func scrubEndpointQuery(endpoint string) string {
 	}
 
 	query := parsedURL.Query()
-	for key, _ := range query { //nolint:gosimple
+	for key, _ := range query { //nolint:staticcheck
 		query[key] = []string{"<redacted>"}
 	}
 

logger/async_test.go

@@ -182,7 +182,7 @@ var _ = Describe("Logger", func() {
 			tick := time.NewTicker(WriteInterval / 10)
 			defer tick.Stop()
 			go func() {
-				for _ = range tick.C { //nolint:gosimple
+				for _ = range tick.C { //nolint:staticcheck
 					logger.Debug("NEW", "new")
 				}
 			}()

logger/logger.go

@@ -39,7 +39,7 @@ func Levelify(levelString string) (LogLevel, error) {
 	level, ok := levels[upperLevelString]
 	if !ok {
 		expected := strings.Join(levelKeys, ", ")
-		return level, fmt.Errorf("Unknown LogLevel string '%s', expected one of [%s]", levelString, expected)
+		return level, fmt.Errorf("Unknown LogLevel string '%s', expected one of [%s]", levelString, expected) //nolint:staticcheck
 	}
 	return level, nil
 }

property/builders.go

@@ -30,7 +30,7 @@ func BuildMap(rawProperties map[interface{}]interface{}) (Map, error) {
 // BuildList creates a new property List from an slice of interface{}, erroring if any elements are maps with non-string keys.
 // Slices in the property List are converted to property Lists. Maps in the property List are converted to property Maps.
 func BuildList(rawProperties []interface{}) (List, error) {
-	result := make(List, len(rawProperties), len(rawProperties)) //nolint:gosimple
+	result := make(List, len(rawProperties), len(rawProperties)) //nolint:staticcheck
 
 	for i, val := range rawProperties {
 		convertedVal, err := Build(val)

system/exec_cmd_runner_test.go

@@ -93,7 +93,7 @@ func unixCommand(cmdName string) Command {
 
 func parseEnvFields(envDump string, convertKeysToUpper bool) map[string]string {
 	fields := make(map[string]string)
-	envDump = strings.Replace(envDump, "\r", "", -1)
+	envDump = strings.Replace(envDump, "\r", "", -1) //nolint:staticcheck
 	for _, line := range strings.Split(envDump, "\n") {
 		// don't split on '=' as '=' is allowed in the value on Windows
 		if n := strings.IndexByte(line, '='); n != -1 {